Re: Scroll bars on macOS builds

[Alan Third <alan@idiocy.org>]

On Sat, Jan 29, 2022 at 04:43:23PM +0100, Angelo Graziosi wrote:
> In any case, the patch below breaks tabbar package from MELPA: I cannot switch buffer clicking on the left-right arrows the package uses to this end. The mouse pointer changes correctly from "arrow" shape to "hand" shape when over those arrows but clicking does not have any effect, the tabs with buffers name should scroll. I DOES NOT scroll.. 
> 
> I attached the screenshot of that element of the tabbar package from MELPA...
> 
> 
> > Il 27/01/2022 23:10 Angelo Graziosi  ha scritto:
> > 
> > I have built current master with patch (do you mean it?) below and it works, i.e. scrollbars are visible!
> > 
> > --- nsterm.m.orig	2022-01-27 22:26:12.000000000 +0100
> > +++ nsterm.m	2022-01-27 22:44:59.000000000 +0100
> > @@ -7195,7 +7195,7 @@
> >       on resize.  Unfortunately it also means the frame will not be
> >       automatically marked for display, but we can do that ourselves in
> >       resizeWithOldSuperviewSize.  */
> > -  [self setWantsLayer:YES];
> > +  [self setWantsLayer:NO];
> >    [self setLayerContentsRedrawPolicy:
> >            NSViewLayerContentsRedrawOnSetNeedsDisplay];
> >    [self setLayerContentsPlacement:NSViewLayerContentsPlacementTopLeft];
> > @@ -7899,7 +7899,6 @@
> >    else
> >      {
> >        [super unlockFocus];
> > -      [super flushWindow];
> >      }
> >  #endif
> >  }

I can't see any way that patch could affect the ability to click on
something. I could understand it perhaps breaking some visual feedback
or something, but the actual click detection has nothing to do with
how the frame is drawn at all.

I'm completely lost with this now.

-- 
Alan Third