unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Brahimi Saifullah <brahimi.saifullah@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: Angelo Graziosi <angelo.g0@libero.it>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: Scroll bars on macOS builds
Date: Sat, 22 Jan 2022 20:10:26 -0300	[thread overview]
Message-ID: <845yqbxt7h.fsf@gmail.com> (raw)
In-Reply-To: <YevrkHrXt2HkPQ1i@idiocy.org> (Alan Third's message of "Sat, 22 Jan 2022 11:33:36 +0000")

Alan Mackenzie <acm@muc.de> writes:

> With the current state of the git branch, flymake on a .el file now
> seems to be working for me.

Yes, Flymake is working perfectly now.

I did notice an issue with the warning for unused forms:

    value returned from (#<symbol + at 2> 1 1) is unused
    (from byte-compiling a file that consists of "(+ 1 1)")

I expect that the symbol should be used, not the symbol with
positions.  But it looks like this just got fixed a few hours ago
in master while my build was from before the merge.


While further testing this I also found a couple problems relating to
unused function arguments -- I'm unsure if they have anything to do with
the latest round of changes or not.

First, a bug:

    (defun f (a b c)
  ; ^^^ Warning: Unused lexical argument `a'
  ;      Warning: Unused lexical argument `b'

    "A B C."
    (+ 1 1))
  ; ^^^ Warning: Unused lexical argument `c'

You should be able to reproduce it by copying the above function
somewhere and byte compiling (sans the).

If the function consists of a single form, the position returned for
the last "unused lexical argument" will wrongly point to it.  In this
example, the warning about C being unused will instead point to `+'.

The second issue is that, even when the unused lexical argument warnings
work correctly, they always point to the "defun," and not to the actual
argument in question.  Not the end of the world of course, but it would
be nice for them to be more accurate.


> Again, many thanks for the help.

And thanks for the work you've done, faulty warning
positions had always been an annoyance of mine :)



      parent reply	other threads:[~2022-01-22 23:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31 21:58 Scroll bars on macOS builds Angelo Graziosi
2022-01-02 14:20 ` Alan Third
2022-01-02 18:41   ` Angelo Graziosi
2022-01-04 11:08     ` Alan Third
2022-01-04 14:29       ` Angelo Graziosi
2022-01-12  0:12       ` Angelo Graziosi
2022-01-22 11:33         ` Alan Third
2022-01-22 15:06           ` Angelo Graziosi
2022-01-22 23:06             ` Tim Cross
2022-01-23 20:11               ` Alan Third
2022-01-23 20:06             ` Alan Third
2022-01-23 21:31               ` Angelo Graziosi
2022-01-23 22:23                 ` Angelo Graziosi
2022-01-25 23:01                   ` Alan Third
2022-01-26 17:07                     ` Angelo Graziosi
2022-01-26 22:31                       ` Alan Third
2022-01-27 19:59                       ` Alan Third
2022-01-27 22:10                         ` Angelo Graziosi
2022-01-29 15:43                           ` Angelo Graziosi
2022-01-30  4:19                             ` Richard Stallman
2022-01-30 22:08                               ` Angelo Graziosi
2022-01-30 12:37                             ` Alan Third
2022-01-30 21:57                               ` Angelo Graziosi
2022-02-03 13:47                               ` Angelo Graziosi
2022-02-03 16:39                                 ` Angelo Graziosi
2022-01-30 12:50                             ` Po Lu
2022-01-30 22:03                               ` Angelo Graziosi
2022-01-27 14:44                     ` Angelo Graziosi
2022-01-27 17:18                     ` Angelo Graziosi
2022-01-22 23:10           ` Brahimi Saifullah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=845yqbxt7h.fsf@gmail.com \
    --to=brahimi.saifullah@gmail.com \
    --cc=alan@idiocy.org \
    --cc=angelo.g0@libero.it \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).