unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Durand <mmemmew@gmail.com>, "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: [External] : [ELPA] Want to submit two packages "ilist" and "blist"
Date: Sun, 19 Sep 2021 17:01:27 +0000	[thread overview]
Message-ID: <SJ0PR10MB54882DC1504AEA0727BF2DB1F3DF9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <m2zgs9rxbp.fsf@gmail.com>

> I have written two Emacs pacakges, called "ilist"
> and "blist" (the former is the "engine", and hence
> a dependency, of the latter).  Now I am thinking
> about submitting the packages to GNU ELPA.
> 
> The package "blist" is to display the list of
> bookmarks, in the sense of "bookmark.el", in a
> similar way as Ibuffer.

As the author of Bookmark+, I want to say that
I'm positively impressed by your attention to
documenting, which I can tell just by looking
at the provided PDFs.

And I commend the features the doc describes.

From just reading that doc, it appears that all
of the Blist features are already features of
Bookmark+.  (Of course, Blist is young.)

That's _good_.  It suggests that such features
are in fact helpful (it corroborates having them
in Bookmark+).

It's also a bit disappointing to me, though, as
I was hoping to find some new features that I
might want to consider for possible addition or
adaptation to Bookmark+, to improve it.  But I
haven't found any that are missing, so far.

It's no doubt worth my looking at the code too
at some point, to see if there are undocumented
features or if there's something else to be
learned from what you've done.

So Bravo!  Thanks for your attention to bookmark
presentation.  And thanks in particular for the
good job documenting what you've created.
___

A minor hiccup we both might want to work around:

Emacs 28 replaced the hard-coded string
"*Bookmark List*" as the name of the list buffer
with the defconst `bookmark-bmenu-buffer' with
that string value.

Both Bookmark+ and blist.el use that "constant",
which means they use the same buffer.  It might
be good for our code to use different variables
for the buffer name.  E.g., I could add and use
a user option `bmkp-bmenu-buffer', whose default
value is that of `bookmark-bmenu-buffer'.  And
you could do similarly.  (Just a suggestion.)
___

A minor suggestion for `blist-filter-groups':
Instead of just telling users to put the default
group at the end of the groups list, you might
want to either do that automatically or provide
an easy way to do that in the Customize UI.

[BTW, you (and users) can directly use the many
 existing Bookmark+ type predicates in Blist
 filter groups: e.g., `bmkp-info-bookmark-p' for
 Info bookmarks, `bmkp-dired-bookmark-p' for
 Dired bookmarks, `bmkp-desktop-bookmark-p' for
 Desktop bookmarks,...

 With Bookmark+ there are no named groups, but
 you can sort by bookmark kind using `s k'.
 You can sort in many (23) ways; sorting by
 bookmark type is one way. ]
___

It's interesting that you took as your point of
departure Ibuffer.  (And it's no doubt useful
to have built blist.el on top of the more
general ilist.el.)

I took Dired as one of my points of departure,
for the bookmark-list display.  The UI is very
close to that of Dired.  But I think that
Ibuffer itself took the Dired UI as a starting
point, so there's a lot of similarity between
where you ended up and where I did, wrt the UI.

Just as I might learn something looking at
what you've done, I invite you to look at what
Bookmark+ does, if you're interested.

https://www.emacswiki.org/emacs/BookmarkPlus



  parent reply	other threads:[~2021-09-19 17:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  4:41 [ELPA] Want to submit two packages "ilist" and "blist" Durand
2021-09-19 10:15 ` Stefan Kangas
2021-09-20  8:39   ` Durand
2021-09-19 12:45 ` Stefan Monnier
2021-09-19 16:33 ` Adam Porter
2021-09-20  0:10   ` Durand
2021-09-20  1:56     ` Adam Porter
2021-09-19 16:43 ` Adam Porter
2021-09-19 23:40   ` Durand
2021-09-19 17:01 ` Drew Adams [this message]
2021-09-19 23:59   ` [External] : " Durand
2021-09-20  4:18     ` Drew Adams
2021-09-20 11:19       ` Durand
2021-09-20 15:25         ` Drew Adams
2021-09-20 23:48   ` Richard Stallman
2021-09-21  0:45     ` Durand
2021-09-20 23:47 ` Richard Stallman
2021-09-21  0:39   ` Durand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB54882DC1504AEA0727BF2DB1F3DF9@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=mmemmew@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).