From: Drew Adams <drew.adams@oracle.com>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: Karl Fogel <kfogel@red-bean.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: RE: [External] : [emacs bookmark.el] Sorting by last set
Date: Tue, 14 Jun 2022 16:36:36 +0000 [thread overview]
Message-ID: <SJ0PR10MB54880A778761AFE9D4B8FE0FF3AA9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <878rpznts7.fsf@elite.giraud>
> I hope it is not to late for this but I'd like to have this
> modification pushed. This changes the field name from
> 'last-modified to 'modified (the symbol for `bookmark-sort-flag'
> is kept to 'last-modified).
>
> I think it make more sense since the "last" in 'last-modified refers to
> the order (ie. the most recently modified will be first). Afterward,
> I'd like to introduce a 'created field too.
My 2 cents:
1. `modified' is fine as the field name. +1.
It's short and clear enough.
2. Function names should include something like
`date' or `time'. This is because there can be
other functions, which refer to other things
about modified (i.e., unsaved) bookmarks.
E.g., the Bookmark+ code has these functions,
which return things such as an alist of just the
modified bookmarks:
bmkp-modified-bookmark-p - predicate
bmkp-modified-cp - predicate
bmkp-modified-bookmarks - alist
bmkp-bmenu-sort-modified-before-unmodified
- sort command
3. +1 for `created'. (I suggested this earlier.)
HTH.
next prev parent reply other threads:[~2022-06-14 16:36 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-04 6:07 [External] : [emacs bookmark.el] Sorting by last set Karl Fogel
2022-06-04 14:36 ` Stefan Monnier
2022-06-04 16:25 ` Drew Adams
2022-06-05 16:16 ` Manuel Giraud
2022-06-05 17:33 ` Drew Adams
2022-06-05 20:53 ` Manuel Giraud
2022-06-05 21:12 ` Stefan Monnier
2022-06-06 0:39 ` Drew Adams
2022-06-07 15:55 ` Manuel Giraud
2022-06-08 11:51 ` Lars Ingebrigtsen
2022-06-06 0:39 ` Drew Adams
2022-06-05 17:53 ` Stefan Monnier
2022-06-07 19:49 ` Karl Fogel
2022-06-08 1:14 ` Drew Adams
2022-06-08 7:57 ` Manuel Giraud
2022-06-08 14:23 ` Drew Adams
2022-06-14 15:34 ` Manuel Giraud
2022-06-14 16:36 ` Drew Adams [this message]
2022-06-15 12:08 ` Lars Ingebrigtsen
2022-06-15 12:32 ` Manuel Giraud
2022-08-18 18:19 ` Karl Fogel
2022-08-31 11:39 ` Manuel Giraud
2022-09-01 1:45 ` Karl Fogel
2022-09-01 2:08 ` Emanuel Berg
-- strict thread matches above, loose matches on Subject: below --
2022-05-24 11:34 Manuel Giraud
2022-05-24 14:41 ` [External] : " Drew Adams
2022-05-24 15:32 ` Manuel Giraud
2022-05-24 15:46 ` Lars Ingebrigtsen
2022-05-25 2:25 ` Karl Fogel
2022-05-25 5:05 ` Drew Adams
2022-05-25 8:04 ` Manuel Giraud
2022-05-25 14:01 ` Drew Adams
2022-05-25 13:18 ` Manuel Giraud
2022-05-25 14:01 ` Drew Adams
2022-05-25 15:25 ` Manuel Giraud
2022-05-25 20:17 ` Drew Adams
2022-05-26 19:41 ` Manuel Giraud
2022-05-26 4:09 ` Karl Fogel
2022-05-26 10:58 ` Lars Ingebrigtsen
2022-05-26 16:42 ` Manuel Giraud
2022-05-26 16:59 ` Stefan Monnier
2022-05-26 20:09 ` Manuel Giraud
2022-05-27 10:34 ` Lars Ingebrigtsen
2022-05-27 13:11 ` Manuel Giraud
2022-05-27 13:20 ` Lars Ingebrigtsen
2022-05-27 13:39 ` Manuel Giraud
2022-05-28 10:34 ` Lars Ingebrigtsen
2022-05-30 14:59 ` Manuel Giraud
2022-05-31 18:36 ` Lars Ingebrigtsen
2022-06-01 6:16 ` Juri Linkov
2022-06-01 8:04 ` Manuel Giraud
2022-06-01 12:18 ` Lars Ingebrigtsen
2022-06-01 12:38 ` Manuel Giraud
2022-06-01 12:08 ` Stefan Monnier
2022-06-01 14:24 ` Drew Adams
2022-06-01 13:45 ` Manuel Giraud
2022-06-01 15:32 ` Lars Ingebrigtsen
2022-06-01 15:56 ` Manuel Giraud
2022-06-01 15:58 ` Lars Ingebrigtsen
2022-06-04 5:33 ` Karl Fogel
2022-05-24 16:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB54880A778761AFE9D4B8FE0FF3AA9@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=larsi@gnus.org \
--cc=manuel@ledu-giraud.fr \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).