Re: [External] : [emacs bookmark.el] Sorting by last set

[Manuel Giraud <manuel@ledu-giraud.fr>]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

I hope it is not to late for this but I'd like to have this modification
pushed.  This changes the field name from 'last-modified to 'modified
(the symbol for `bookmark-sort-flag' is kept to 'last-modified).

I think it make more sense since the "last" in 'last-modified refers to
the order (ie. the most recently modified will be first).  Afterward,
I'd like to introduce a 'created field too.

Best regards,

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Change-last-modified-field-name-to-modified.patch --]
[-- Type: text/x-patch, Size: 3725 bytes --]

From 7fe15765e2777d5e001558d6648c7d5f250d34bc Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Tue, 14 Jun 2022 17:22:04 +0200
Subject: [PATCH] Change 'last-modified field name to 'modified

* lisp/bookmark.el: change 'last-modified field name to 'modified
---
 lisp/bookmark.el | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index b0b54e52d8..64b8ee7f5e 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -469,14 +469,14 @@ bookmark-get-handler
   (bookmark-prop-get bookmark-name-or-record 'handler))
 
 
-(defun bookmark-get-last-modified (bookmark-name-or-record)
-  "Return the last-modified for BOOKMARK-NAME-OR-RECORD, or nil if none."
-  (bookmark-prop-get bookmark-name-or-record 'last-modified))
+(defun bookmark-get-modified (bookmark-name-or-record)
+  "Return the modified for BOOKMARK-NAME-OR-RECORD, or nil if none."
+  (bookmark-prop-get bookmark-name-or-record 'modified))
 
 
-(defun bookmark-update-last-modified (bookmark-name-or-record)
-  "Update the last-modified date of BOOKMARK-NAME-OR-RECORD to the current time."
-  (bookmark-prop-set bookmark-name-or-record 'last-modified (current-time)))
+(defun bookmark-update-modified (bookmark-name-or-record)
+  "Update the modified date of BOOKMARK-NAME-OR-RECORD to the current time."
+  (bookmark-prop-set bookmark-name-or-record 'modified (current-time)))
 
 
 (defvar bookmark-history nil
@@ -527,8 +527,8 @@ bookmark-maybe-sort-alist
            (sort copy (lambda (x y) (string-lessp (car x) (car y)))))
           ((eq bookmark-sort-flag 'last-modified)
            (sort copy (lambda (x y)
-                        (let ((tx (bookmark-get-last-modified x))
-                              (ty (bookmark-get-last-modified y)))
+                        (let ((tx (bookmark-get-modified x))
+                              (ty (bookmark-get-modified y)))
                           (cond ((null tx) nil)
                                 ((null ty) t)
                                 (t (time-less-p ty tx)))))))
@@ -666,7 +666,7 @@ bookmark-make-record-default
                                    (- (point) bookmark-search-size))
                                   nil))))
     (position . ,(or posn (point)))
-    (last-modified . ,(current-time))))
+    (modified . ,(current-time))))
 
 \f
 ;;; File format stuff
@@ -1076,7 +1076,7 @@ bookmark-send-edited-annotation
         (from-bookmark-list bookmark--annotation-from-bookmark-list)
         (old-buffer (current-buffer)))
     (bookmark-set-annotation bookmark-name annotation)
-    (bookmark-update-last-modified bookmark-name)
+    (bookmark-update-modified bookmark-name)
     (setq bookmark-alist-modification-count
           (1+ bookmark-alist-modification-count))
     (message "Annotation updated for \"%s\"" bookmark-name)
@@ -1363,7 +1363,7 @@ bookmark-relocate
                     (format "Relocate %s to: " bookmark-name)
                     (file-name-directory bmrk-filename))))))
     (bookmark-set-filename bookmark-name newloc)
-    (bookmark-update-last-modified bookmark-name)
+    (bookmark-update-modified bookmark-name)
     (setq bookmark-alist-modification-count
           (1+ bookmark-alist-modification-count))
     (if (bookmark-time-to-save-p)
@@ -1426,7 +1426,7 @@ bookmark-rename
               nil
               'bookmark-history))))
     (bookmark-set-name old-name final-new-name)
-    (bookmark-update-last-modified final-new-name)
+    (bookmark-update-modified final-new-name)
     (setq bookmark-current-bookmark final-new-name)
     (bookmark-bmenu-surreptitiously-rebuild-list)
     (setq bookmark-alist-modification-count
-- 
2.36.1


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud