From: Eli Zaretskii <eliz@is.elta.co.il>
Cc: Ben Key <Bkey1@tampabay.rr.com>,
emacs-devel@gnu.org, jasonr@btinternet.com
Subject: Re: Updated patch for a Windows implementation of play-sound
Date: Wed, 23 Oct 2002 08:16:08 +0200 (IST) [thread overview]
Message-ID: <Pine.SUN.3.91.1021023081341.13511G-100000@is> (raw)
In-Reply-To: <200210230530.g9N5U3q05183@rum.cs.yale.edu>
On Wed, 23 Oct 2002, Stefan Monnier wrote:
> How about not adding a new file w32sound.c but instead adding the
> corresponding code to sound.c (and of course wrap things in
> #ifdef WINDOWSNT
Yes, I agree wholeheartedly. Platform-specific source files are a pain;
adding one more is something we should avoid IMHO.
sound.c is sufficiently small and already has lots of #ifdef's that test
for specific systems, so adding another such portion won't change
anything.
> (or _WIN32, I don't know what is what: most of
> the Emacs C code I've seen seems to be using WINDOWSNT)).
It's WINDOWSNT to avoid calling Windows ``a win'' ;-)
prev parent reply other threads:[~2002-10-23 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-23 4:59 Updated patch for a Windows implementation of play-sound Ben Key
2002-10-23 5:30 ` Stefan Monnier
2002-10-23 6:16 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1021023081341.13511G-100000@is \
--to=eliz@is.elta.co.il \
--cc=Bkey1@tampabay.rr.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@btinternet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).