From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Updated patch for a Windows implementation of play-sound Date: Wed, 23 Oct 2002 08:16:08 +0200 (IST) Sender: emacs-devel-admin@gnu.org Message-ID: References: <200210230530.g9N5U3q05183@rum.cs.yale.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: main.gmane.org 1035354014 15595 80.91.224.249 (23 Oct 2002 06:20:14 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 23 Oct 2002 06:20:14 +0000 (UTC) Cc: Ben Key , emacs-devel@gnu.org, jasonr@btinternet.com Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 184EsE-00043G-00 for ; Wed, 23 Oct 2002 08:20:10 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 184Etn-0006Wa-00 for ; Wed, 23 Oct 2002 08:21:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 184EpV-0000mi-00; Wed, 23 Oct 2002 02:17:21 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 184EoM-000725-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 02:16:10 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 184EoK-0006zH-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 02:16:09 -0400 Original-Received: from is.elta.co.il ([199.203.121.2]) by monty-python.gnu.org with esmtp (Exim 4.10) id 184EoJ-0006rS-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 02:16:08 -0400 Original-Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA13955; Wed, 23 Oct 2002 08:16:08 +0200 (IST) X-Sender: eliz@is Original-To: Stefan Monnier In-Reply-To: <200210230530.g9N5U3q05183@rum.cs.yale.edu> Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8670 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8670 On Wed, 23 Oct 2002, Stefan Monnier wrote: > How about not adding a new file w32sound.c but instead adding the > corresponding code to sound.c (and of course wrap things in > #ifdef WINDOWSNT Yes, I agree wholeheartedly. Platform-specific source files are a pain; adding one more is something we should avoid IMHO. sound.c is sufficiently small and already has lots of #ifdef's that test for specific systems, so adding another such portion won't change anything. > (or _WIN32, I don't know what is what: most of > the Emacs C code I've seen seems to be using WINDOWSNT)). It's WINDOWSNT to avoid calling Windows ``a win'' ;-)