unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Juri Linkov'" <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: RE: Why is `C-x 8' limited to Latin-1 for search?
Date: Mon, 10 Dec 2012 16:11:26 -0800	[thread overview]
Message-ID: <FC14B92069AA45F2B1C6B19AB6B493E3@us.oracle.com> (raw)
In-Reply-To: <87zk1lfu4j.fsf@mail.jurta.org>

> > But I don't know what you mean by "except the part that changes
> > `isearch-new-string' and `isearch-new-message'.  I do 
> > change both, to reflect the added char.  No doubt you had a
> > slightly different macro in mind.
> 
> I meant that `isearch-edit-string' does more than needed for 
> the command that will read and insert an Unicode char.  For example,
> currently it binds `history-add-new-input' to nil.  This means that
> your code doesn't add the char name to the minibuffer's history.

Yes, your macro is the same as mine, except that you do not include these 3
bindings (you use them only in `isearch-edit-string'):

 (message-log-max           nil)
 (history-add-new-input     nil)
 (minibuffer-history-symbol nil)

And you do not update `isearch-new-string' and `isearch-new-message' in the
macro itself, but outside it (in the macro callers).

> (define-key isearch-mode-map "\M-r"
>   (lambda ()
>     (interactive)
>     (with-isearch-suspend (recursive-edit))))
>
> `C-M-c' will continue the suspended isearch.

Your tweak improves the macro - my vote says go for it.

I suggest changing the name slightly: `with-isearch-suspended' (or perhaps just
`isearch-suspend').




  reply	other threads:[~2012-12-11  0:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09  4:52 Why is `C-x 8' limited to Latin-1 for search? Drew Adams
2012-12-09  5:33 ` Drew Adams
2012-12-10  7:46   ` Juri Linkov
2012-12-10 14:24     ` Drew Adams
2012-12-10 21:57       ` Juri Linkov
2012-12-11  0:11         ` Drew Adams [this message]
2012-12-10  7:45 ` Juri Linkov
2012-12-10 14:44   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC14B92069AA45F2B1C6B19AB6B493E3@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).