unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Juri Linkov'" <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: RE: Why is `C-x 8' limited to Latin-1 for search?
Date: Mon, 10 Dec 2012 06:44:42 -0800	[thread overview]
Message-ID: <9B10F36F6C4546408A98CE77D6EC55B2@us.oracle.com> (raw)
In-Reply-To: <871uey5zv6.fsf@mail.jurta.org>

> Shouldn't users be able to insert Unicode characters in any 
> minibuffer, not only in `isearch-edit-string'?  If these is no
> reason to disallow, this patch should allow this for
> `completing-read' in `read-char-by-name':
> 
> +  (let* ((enable-recursive-minibuffers t)

FWIW, I typically add such a binding not to a function like this but to
functions that call it.  `read-char-by-name' does not know whether it is being
called from a minibuffer, i.e., whether it needs such a binding, but a function
that calls it generally does know that.

I don't think there is necessarily something wrong with doing what you suggest,
so I have no objection.  I just generally prefer to do only what the current
code knows it needs.

One could make an even more radical suggestion than yours: that
`enable-recursive-minibuffers' simply be non-nil by default.  (I am not
suggesting that.)  But the design intention in the past has been to not bind it
to non-nil any more than necessary because it has been thought that recursive
minibuffers entered accidentally can confuse users.

I use mb-depth.el (which I tweak to use a simpler depth indicator and to let
users customize it).  That helps a lot wrt recursive minibuffers.  The main
confusion about recursive minibuffers is not knowing that you are in one or how
deep it is.

With mb-depth.el (which should be turned on by default, IMHO), I'm not sure how
much the original design decision of avoiding non-nil
`enable-recursive-minibuffers' is still appropriate/necessary.




      reply	other threads:[~2012-12-10 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09  4:52 Why is `C-x 8' limited to Latin-1 for search? Drew Adams
2012-12-09  5:33 ` Drew Adams
2012-12-10  7:46   ` Juri Linkov
2012-12-10 14:24     ` Drew Adams
2012-12-10 21:57       ` Juri Linkov
2012-12-11  0:11         ` Drew Adams
2012-12-10  7:45 ` Juri Linkov
2012-12-10 14:44   ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9B10F36F6C4546408A98CE77D6EC55B2@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).