* get-buffer-window should prefer windows on selected frame
@ 2005-12-05 16:11 Stefan Monnier
2005-12-05 17:01 ` Lennart Borgman
2005-12-12 5:24 ` Richard M. Stallman
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Monnier @ 2005-12-05 16:11 UTC (permalink / raw)
get-buffer-window currently favors returning the selected-window (if it
shows the requested buffer, of course) over other windows.
I think this should be extended so that if the selected-window doesn't show
the buffer, but some other window on the selected frame does show it, that
window should be picked in preference to other windows on other frames.
Any objection to the patch below?
Stefan
Index: src/window.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/window.c,v
retrieving revision 1.529
diff -u -r1.529 window.c
--- src/window.c 1 Dec 2005 16:25:15 -0000 1.529
+++ src/window.c 5 Dec 2005 16:07:28 -0000
@@ -1996,8 +1996,10 @@
if (NILP (best_window))
best_window = window;
else if (EQ (window, selected_window))
- /* For compatibility with 20.x, prefer to return
- selected-window. */
+ /* Prefer to return selected-window. */
+ RETURN_UNGCPRO (window);
+ else if (EQ (Fwindow_frame (window), selected_frame))
+ /* Prefer windows on the current frame. */
best_window = window;
}
break;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: get-buffer-window should prefer windows on selected frame
2005-12-05 16:11 get-buffer-window should prefer windows on selected frame Stefan Monnier
@ 2005-12-05 17:01 ` Lennart Borgman
2005-12-12 5:24 ` Richard M. Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Lennart Borgman @ 2005-12-05 17:01 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier wrote:
>get-buffer-window currently favors returning the selected-window (if it
>shows the requested buffer, of course) over other windows.
>
>I think this should be extended so that if the selected-window doesn't show
>the buffer, but some other window on the selected frame does show it, that
>window should be picked in preference to other windows on other frames.
>
>Any objection to the patch below?
>
>
Sounds good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: get-buffer-window should prefer windows on selected frame
2005-12-05 16:11 get-buffer-window should prefer windows on selected frame Stefan Monnier
2005-12-05 17:01 ` Lennart Borgman
@ 2005-12-12 5:24 ` Richard M. Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Richard M. Stallman @ 2005-12-12 5:24 UTC (permalink / raw)
Cc: emacs-devel
get-buffer-window currently favors returning the selected-window (if it
shows the requested buffer, of course) over other windows.
I think this should be extended so that if the selected-window doesn't show
the buffer, but some other window on the selected frame does show it, that
window should be picked in preference to other windows on other frames.
Any objection to the patch below?
It may be a good idea, but since it isn't a bug fix and isn't crucial,
please save it for after the release.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-12 5:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-05 16:11 get-buffer-window should prefer windows on selected frame Stefan Monnier
2005-12-05 17:01 ` Lennart Borgman
2005-12-12 5:24 ` Richard M. Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).