[PATCH] Add --enable-locallisppath option to configure.in

[PATCH] Add --enable-locallisppath option to configure.in

[Jérôme Marant]

Hi,

Currently, only the configure script generates epaths, by calling the
'epaths-force' target of the Makefile.

However, it is not possible to customize the value of the
locallisppath variable in order to include it in epaths at
configure-time, which makes necessary to re-run 'make epaths-force'
with a customized locallisppath.

The following patch adds a --enable-locallisppath option for this
purpose. It attemps to follow the --enable-* options semantic:

  --enable-locallisppath, --enable-locallisppath=yes: leaves the default value

  --disable-locallisppath, --enable-locallisppath=no: removes locallisppath
    from lisppath

  --enable-locallisppath=PATH: set locallisppath and adds it to lisppath

Cheers,

diff -u -r emacs.orig/ChangeLog emacs/ChangeLog
--- emacs.orig/ChangeLog	2005-05-11 13:40:41.277147000 +0200
+++ emacs/ChangeLog	2005-05-11 14:10:26.254789616 +0200
@@ -1,3 +1,7 @@
+2005-05-11  Jerome Marant  <jmarant@marant.org>
+
+	* configure.in: Add --enable-locallisppath.
+
 2005-05-07  Jérôme Marant  <jerome@marant.org>
 
 	* make-dist: Remove references to makefile.nt and makefile.def.
diff -u -r emacs.orig/configure.in emacs/configure.in
--- emacs.orig/configure.in	2005-05-11 13:40:01.004269000 +0200
+++ emacs/configure.in	2005-05-11 14:16:04.669342784 +0200
@@ -142,6 +142,18 @@
 fi
 AC_SUBST(MAINT)
 
+AC_ARG_ENABLE(locallisppath,
+[  --enable-locallisppath=PATH
+                          directories Emacs should search for lisp files
+                          specific to this site],
+if test "${enableval}" = "no"; then
+  locallisppath=
+  lisppath=${lispdir}
+elif test "${enableval}" != "yes"; then
+  locallisppath=${enableval}
+  lisppath=${locallisppath}:${lispdir}
+fi)
+
 #### Make srcdir absolute, if it isn't already.  It's important to
 #### avoid running the path through pwd unnecessarily, since pwd can
 #### give you automounter prefixes, which can go away.  We do all this


-- 
Jérôme Marant

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Jérôme Marant]

Jérôme Marant <jmarant@free.fr> writes:

> Hi,
>
> Currently, only the configure script generates epaths, by calling the
> 'epaths-force' target of the Makefile.
>
> However, it is not possible to customize the value of the
> locallisppath variable in order to include it in epaths at
> configure-time, which makes necessary to re-run 'make epaths-force'
> with a customized locallisppath.
>
> The following patch adds a --enable-locallisppath option for this
> purpose. It attemps to follow the --enable-* options semantic:

This one should be better:

diff -u -r emacs.orig/ChangeLog emacs/ChangeLog
--- emacs.orig/ChangeLog	2005-05-11 13:40:41.277147000 +0200
+++ emacs/ChangeLog	2005-05-11 14:10:26.254789616 +0200
@@ -1,3 +1,7 @@
+2005-05-11  Jerome Marant  <jmarant@marant.org>
+
+	* configure.in: Add --enable-locallisppath.
+
 2005-05-07  Jérôme Marant  <jerome@marant.org>
 
 	* make-dist: Remove references to makefile.nt and makefile.def.
diff -u -r emacs.orig/configure.in emacs/configure.in
--- emacs.orig/configure.in	2005-05-11 13:40:01.004269000 +0200
+++ emacs/configure.in	2005-05-11 14:16:04.669342784 +0200
@@ -142,6 +142,18 @@
 fi
 AC_SUBST(MAINT)
 
+AC_ARG_ENABLE(locallisppath,
+[  --enable-locallisppath=PATH
+                          directories Emacs should search for lisp files
+                          specific to this site],
+if test "${enableval}" = "no"; then
+  locallisppath=
+  lisppath='${lispdir}'
+elif test "${enableval}" != "yes"; then
+  locallisppath=${enableval}
+  lisppath='${locallisppath}:${lispdir}'
+fi)
+
 #### Make srcdir absolute, if it isn't already.  It's important to
 #### avoid running the path through pwd unnecessarily, since pwd can
 #### give you automounter prefixes, which can go away.  We do all this


-- 
Jérôme Marant

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Jérôme Marant]

Hi,

Would anybody be kind to either consider or reject this small patch or
maybe propose a better way to achieve the goal?
I haven't read any comment so far.

(Here is an update)

Thanks in advance.

Jérôme Marant <jmarant@free.fr> writes:

> Jérôme Marant <jmarant@free.fr> writes:
>
>> Hi,
>>
>> Currently, only the configure script generates epaths, by calling the
>> 'epaths-force' target of the Makefile.
>>
>> However, it is not possible to customize the value of the
>> locallisppath variable in order to include it in epaths at
>> configure-time, which makes necessary to re-run 'make epaths-force'
>> with a customized locallisppath.
>>
>> The following patch adds a --enable-locallisppath option for this
>> purpose. It attemps to follow the --enable-* options semantic:
>
> This one should be better:

diff -ur emacs.orig/ChangeLog emacs/ChangeLog
--- emacs.orig/ChangeLog	2005-05-10 22:28:12.000000000 +0200
+++ emacs/ChangeLog	2005-05-18 20:01:34.388771568 +0200
@@ -1,3 +1,7 @@
+2005-05-11  Jerome Marant  <jmarant@marant.org>
+
+	* configure.in: Add --enable-locallisppath.
+
 2005-05-07  Jérôme Marant  <jerome@marant.org>
 
 	* make-dist: Remove references to makefile.nt and makefile.def.
diff -ur emacs.orig/configure.in emacs/configure.in
--- emacs.orig/configure.in	2005-04-23 19:02:09.000000000 +0200
+++ emacs/configure.in	2005-05-18 20:02:51.733013456 +0200
@@ -142,6 +142,16 @@
 fi
 AC_SUBST(MAINT)
 
+AC_ARG_ENABLE(locallisppath,
+[  --enable-locallisppath=PATH
+                          directories Emacs should search for lisp files
+                          specific to this site],
+if test "${enableval}" = "no"; then
+  locallisppath=
+elif test "${enableval}" != "yes"; then
+  locallisppath=${enableval}
+fi)
+
 #### Make srcdir absolute, if it isn't already.  It's important to
 #### avoid running the path through pwd unnecessarily, since pwd can
 #### give you automounter prefixes, which can go away.  We do all this


-- 
Jérôme Marant

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Lute Kamstra]

Hi Jérôme,

> Would anybody be kind to either consider or reject this small patch or
> maybe propose a better way to achieve the goal?
> I haven't read any comment so far.
>
> (Here is an update)
>
> Thanks in advance.
>
> Jérôme Marant <jmarant@free.fr> writes:
>
>> Jérôme Marant <jmarant@free.fr> writes:
>>
>>> Hi,
>>>
>>> Currently, only the configure script generates epaths, by calling the
>>> 'epaths-force' target of the Makefile.
>>>
>>> However, it is not possible to customize the value of the
>>> locallisppath variable in order to include it in epaths at
>>> configure-time, which makes necessary to re-run 'make epaths-force'
>>> with a customized locallisppath.
>>>
>>> The following patch adds a --enable-locallisppath option for this
>>> purpose. It attemps to follow the --enable-* options semantic:
>>
>> This one should be better:
>
> diff -ur emacs.orig/ChangeLog emacs/ChangeLog
> --- emacs.orig/ChangeLog	2005-05-10 22:28:12.000000000 +0200
> +++ emacs/ChangeLog	2005-05-18 20:01:34.388771568 +0200
> @@ -1,3 +1,7 @@
> +2005-05-11  Jerome Marant  <jmarant@marant.org>
> +
> +	* configure.in: Add --enable-locallisppath.
> +
>  2005-05-07  Jérôme Marant  <jerome@marant.org>
>  
>  	* make-dist: Remove references to makefile.nt and makefile.def.
> diff -ur emacs.orig/configure.in emacs/configure.in
> --- emacs.orig/configure.in	2005-04-23 19:02:09.000000000 +0200
> +++ emacs/configure.in	2005-05-18 20:02:51.733013456 +0200
> @@ -142,6 +142,16 @@
>  fi
>  AC_SUBST(MAINT)
>  
> +AC_ARG_ENABLE(locallisppath,
> +[  --enable-locallisppath=PATH
> +                          directories Emacs should search for lisp files
> +                          specific to this site],
> +if test "${enableval}" = "no"; then
> +  locallisppath=
> +elif test "${enableval}" != "yes"; then
> +  locallisppath=${enableval}
> +fi)
> +
>  #### Make srcdir absolute, if it isn't already.  It's important to
>  #### avoid running the path through pwd unnecessarily, since pwd can
>  #### give you automounter prefixes, which can go away.  We do all this

Could you explain what you want to accomplish?  It seems to me that you
want to be able to _add_ a dir to locallisppath.  However, when you do
"./configure --enable-locallisppath=/my/dir", you _replace_ the default
value of locallisppath (which is '${datadir}/emacs/${version}/site-lisp:'\
'${datadir}/emacs/site-lisp:${datadir}/emacs/${version}/leim') with
/my/dir.

Lute.

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Richard Stallman]

This patch is ok; would someone please install it?

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Jérôme Marant]

Quoting Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>:


> Could you explain what you want to accomplish?  It seems to me that you

I think I already explained in my previous messages: it is a way to avoid
running make epaths-force again since configure already runs it: we'd
better feed configure with the locallisppath we want directly.

> want to be able to _add_ a dir to locallisppath.  However, when you do
> "./configure --enable-locallisppath=/my/dir", you _replace_ the default
> value of locallisppath (which is '${datadir}/emacs/${version}/site-lisp:'\
> '${datadir}/emacs/site-lisp:${datadir}/emacs/${version}/leim') with
> /my/dir.

Yes I do. The locallisppath is very dependant on the site and might vary
w.r.t. platforms. Not using this option will leave the variable unchanged.

Do you have anything better to propose?

Cheers,

--
Jérôme Marant

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Lute Kamstra]

Richard Stallman <rms@gnu.org> writes:

> This patch is ok; would someone please install it?

Done.

Lute.

Re: [PATCH] Add --enable-locallisppath option to configure.in

[Jérôme Marant]

Quoting Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>:

> Richard Stallman <rms@gnu.org> writes:
>
> > This patch is ok; would someone please install it?
>
> Done.

Thank you.

--
Jérôme Marant