From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: lispref/frames.texi and xmenu.c
Date: Sun, 01 May 2005 14:57:16 -0400 [thread overview]
Message-ID: <E1DSJcy-0003dU-LV@fencepost.gnu.org> (raw)
In-Reply-To: <200505011335.j41DZK123269@raven.dms.auburn.edu> (message from Luc Teirlinck on Sun, 1 May 2005 08:35:20 -0500 (CDT))
Studying the code, I see that the original x-popup-menu in the non-Xt
case does quit if the user cancels, except in the case where it was
invoked for a mouse click. (This is determined by the POSITION
argument.) When the code was adapted to Xt, that part of the
functionality was lost, it looks like.
Seeing this, I concluded that the right thing to do is to make all the
implementations of x-popup-menu quit also, under the same condition.
I implemented this in xmenu.c, but not in w32menu.c and macmenu.c.
Would you please document this behavior?
Aside from that issue, the manual changes are good, but
! The argument @var{menu} says what to display in the menu.
!
please delete that blank line.
Regarding the doc strings:
! This function returns nil if the user quits or pops down the menu
! without making a valid choice. Note that this differs from
! `x-popup-dialog', which quits without returning a value in these
! situations. */)
! If the user pops down the dialog box without making a valid choice,
! then this produces a quit and the function returns no value. Note
! that this differs from `x-popup-menu', which returns nil in this
! situation. */)
There's no need for each function to talk about what the other does.
Just document what each function does when the user exits without a
selection.
next prev parent reply other threads:[~2005-05-01 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 13:35 lispref/frames.texi and xmenu.c Luc Teirlinck
2005-05-01 13:45 ` Andreas Schwab
2005-05-01 13:56 ` Luc Teirlinck
2005-05-01 14:06 ` Luc Teirlinck
2005-05-01 17:43 ` Jan D.
2005-05-01 21:04 ` Luc Teirlinck
2005-05-01 18:57 ` Richard Stallman [this message]
2005-05-01 20:32 ` Luc Teirlinck
2005-05-02 3:06 ` Luc Teirlinck
2005-05-02 23:40 ` Richard Stallman
2005-05-03 23:11 ` Luc Teirlinck
2005-05-04 22:05 ` Richard Stallman
2005-05-05 3:04 ` Luc Teirlinck
2005-05-05 19:46 ` Richard Stallman
2005-05-02 3:28 ` Luc Teirlinck
2005-05-01 19:01 ` Eli Zaretskii
2005-05-01 20:55 ` Luc Teirlinck
2005-05-02 3:33 ` Luc Teirlinck
-- strict thread matches above, loose matches on Subject: below --
2005-04-30 2:02 Luc Teirlinck
2005-05-01 18:48 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DSJcy-0003dU-LV@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).