From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: lispref/frames.texi and xmenu.c Date: Sun, 01 May 2005 14:57:16 -0400 Message-ID: References: <200505011335.j41DZK123269@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1114976329 21646 80.91.229.2 (1 May 2005 19:38:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 1 May 2005 19:38:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 01 21:38:47 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DSKGw-0001lh-8g for ged-emacs-devel@m.gmane.org; Sun, 01 May 2005 21:38:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSKNh-0008Us-3W for ged-emacs-devel@m.gmane.org; Sun, 01 May 2005 15:45:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DSJox-0007HB-Vg for emacs-devel@gnu.org; Sun, 01 May 2005 15:09:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DSJox-0007Gp-Cd for emacs-devel@gnu.org; Sun, 01 May 2005 15:09:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSJmr-0005qN-65 for emacs-devel@gnu.org; Sun, 01 May 2005 15:07:29 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DSJhF-0002mi-Sb for emacs-devel@gnu.org; Sun, 01 May 2005 15:01:41 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DSJcy-0003dU-LV; Sun, 01 May 2005 14:57:16 -0400 Original-To: Luc Teirlinck In-reply-to: <200505011335.j41DZK123269@raven.dms.auburn.edu> (message from Luc Teirlinck on Sun, 1 May 2005 08:35:20 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36554 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36554 Studying the code, I see that the original x-popup-menu in the non-Xt case does quit if the user cancels, except in the case where it was invoked for a mouse click. (This is determined by the POSITION argument.) When the code was adapted to Xt, that part of the functionality was lost, it looks like. Seeing this, I concluded that the right thing to do is to make all the implementations of x-popup-menu quit also, under the same condition. I implemented this in xmenu.c, but not in w32menu.c and macmenu.c. Would you please document this behavior? Aside from that issue, the manual changes are good, but ! The argument @var{menu} says what to display in the menu. ! please delete that blank line. Regarding the doc strings: ! This function returns nil if the user quits or pops down the menu ! without making a valid choice. Note that this differs from ! `x-popup-dialog', which quits without returning a value in these ! situations. */) ! If the user pops down the dialog box without making a valid choice, ! then this produces a quit and the function returns no value. Note ! that this differs from `x-popup-menu', which returns nil in this ! situation. */) There's no need for each function to talk about what the other does. Just document what each function does when the user exits without a selection.