unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Deleting skeleton-proxy
@ 2003-05-23  0:42 Stefan Monnier
  2003-05-24 23:20 ` Richard Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2003-05-23  0:42 UTC (permalink / raw)



While looking at abbrevs and friends, I bumped into the skeleton-proxy horror.
Trying to understand what happened, I finally discovered that
skeleton used to use something like

	(defmacro define-skeleton (name &rest skel)
          `(progn (defvar ,name ',skel)
	          (defalias ',name 'skeleton-proxy)))

and so skeleton-proxy looked up the stack to find the name of the
alias used, then looked up the var-binding of that name to find
the actual skeleton.

Someone (apparently Richard) saw how disgusting it was and fixed it
to do the right thing.  This was way back in 96.

	revision 1.15
	date: 1996/06/28 08:11:18;  author: rms;  state: Exp;  lines: +53 -3
	(skeleton-proxy-new): New function.
	(define-skeleton): Define the skeleton as a defun
	using skeleton-proxy-new.

Now, skeleton-proxy was kept at that time because it was still needed
by code byte-compiled with the old macro.  I don't know if the code
still works (its stack-walking thing is something that I'd expect to
break at least somewhat in the course of 7 years), but it is still
autoloaded.

Any objection to getting rid of this thing ?


	Stefan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Deleting skeleton-proxy
  2003-05-23  0:42 Deleting skeleton-proxy Stefan Monnier
@ 2003-05-24 23:20 ` Richard Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2003-05-24 23:20 UTC (permalink / raw)
  Cc: emacs-devel

    Now, skeleton-proxy was kept at that time because it was still needed
    by code byte-compiled with the old macro.  I don't know if the code
    still works (its stack-walking thing is something that I'd expect to
    break at least somewhat in the course of 7 years), but it is still
    autoloaded.

    Any objection to getting rid of this thing ?

I don't think those old byte-compiled files would even work now, if
there are any.  So please get rid of it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-05-24 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-23  0:42 Deleting skeleton-proxy Stefan Monnier
2003-05-24 23:20 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).