unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: covici@ccs.covici.com
Subject: Re: loading vm reader causes fatal error
Date: Fri, 23 May 2003 08:04:29 -0400	[thread overview]
Message-ID: <E19JBHh-0006MK-Vk@fencepost.gnu.org> (raw)
In-Reply-To: <3rn0hgurnb.fsf@xpc14.ast.cam.ac.uk> (message from Glenn Morris on Wed, 21 May 2003 18:38:16 +0100)

It looks like the crash is caused by the change below.  I put it in
because I got the impression that the lface was never newly created
here.  It seemed to have been created earlier.

This change can certainly be taken out, but before you do that, could
you determine in what case it happens that the lface for default is
not created earlier?

***************
*** 6590,6600 ****
    /* If the `default' face is not yet known, create it.  */
    lface = lface_from_face_name (f, Qdefault, 0);
    if (NILP (lface))
!     {
!       Lisp_Object frame;
!       XSETFRAME (frame, f);
!       lface = Finternal_make_lisp_face (Qdefault, frame);
!     }
  
  #ifdef HAVE_WINDOW_SYSTEM
    if (FRAME_WINDOW_P (f))
--- 6594,6600 ----
    /* If the `default' face is not yet known, create it.  */
    lface = lface_from_face_name (f, Qdefault, 0);
    if (NILP (lface))
!     abort ();
  
  #ifdef HAVE_WINDOW_SYSTEM
    if (FRAME_WINDOW_P (f))

  parent reply	other threads:[~2003-05-23 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-19 17:28 loading vm reader causes fatal error John Covici
2003-05-21 17:38 ` Glenn Morris
2003-05-21 21:32   ` John covici
2003-05-23 12:04   ` Richard Stallman [this message]
2003-05-29 17:11     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E19JBHh-0006MK-Vk@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=covici@ccs.covici.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).