From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: loading vm reader causes fatal error Date: Fri, 23 May 2003 08:04:29 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3rn0hgurnb.fsf@xpc14.ast.cam.ac.uk> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1053692290 12011 80.91.224.249 (23 May 2003 12:18:10 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 23 May 2003 12:18:10 +0000 (UTC) Cc: covici@ccs.covici.com Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 23 14:18:09 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19JBOi-0002VC-00 for ; Fri, 23 May 2003 14:11:44 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19JBaS-0001YZ-00 for ; Fri, 23 May 2003 14:23:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JBLm-00043T-RC for emacs-devel@quimby.gnus.org; Fri, 23 May 2003 08:08:42 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19JBKv-0003nd-Bi for emacs-devel@gnu.org; Fri, 23 May 2003 08:07:49 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19JBHo-00027I-Iw for emacs-devel@gnu.org; Fri, 23 May 2003 08:04:37 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19JBHi-00021g-EF for emacs-devel@gnu.org; Fri, 23 May 2003 08:04:30 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.20) id 19JBHh-0006MK-Vk; Fri, 23 May 2003 08:04:29 -0400 Original-To: Glenn Morris In-reply-to: <3rn0hgurnb.fsf@xpc14.ast.cam.ac.uk> (message from Glenn Morris on Wed, 21 May 2003 18:38:16 +0100) Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14127 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14127 It looks like the crash is caused by the change below. I put it in because I got the impression that the lface was never newly created here. It seemed to have been created earlier. This change can certainly be taken out, but before you do that, could you determine in what case it happens that the lface for default is not created earlier? *************** *** 6590,6600 **** /* If the `default' face is not yet known, create it. */ lface = lface_from_face_name (f, Qdefault, 0); if (NILP (lface)) ! { ! Lisp_Object frame; ! XSETFRAME (frame, f); ! lface = Finternal_make_lisp_face (Qdefault, frame); ! } #ifdef HAVE_WINDOW_SYSTEM if (FRAME_WINDOW_P (f)) --- 6594,6600 ---- /* If the `default' face is not yet known, create it. */ lface = lface_from_face_name (f, Qdefault, 0); if (NILP (lface)) ! abort (); #ifdef HAVE_WINDOW_SYSTEM if (FRAME_WINDOW_P (f))