unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* bad checkdoc/eldoc interaction
@ 2003-01-02 23:52 John Paul Wallington
  0 siblings, 0 replies; only message in thread
From: John Paul Wallington @ 2003-01-02 23:52 UTC (permalink / raw)


Presently, if you do

emacs -q --no-site-file
(require 'checkdoc)
M-x eldoc-mode

then eldoc will print "nil: Checkdoc Minor Mode Menu" when it has
nothing to say.

One fix is for `eldoc-get-var-docstring' to only return the
documentation if sym is non-nil (see below).  Before making the change
I would like to check that it isn't hiding a greater problem, so
please holler if it shouldn't be installed.


diff -u -b -r1.21 eldoc.el
--- eldoc.el	19 Nov 2002 23:32:54 -0000	1.21
+++ eldoc.el	2 Jan 2003 23:41:03 -0000
@@ -327,6 +327,7 @@
 ;; Return a string containing a brief (one-line) documentation string for
 ;; the variable.
 (defun eldoc-get-var-docstring (sym)
+  (when sym
   (cond ((and (eq sym (aref eldoc-last-data 0))
               (eq 'variable (aref eldoc-last-data 2)))
          (aref eldoc-last-data 1))
@@ -336,7 +337,7 @@
                   (setq doc (eldoc-docstring-format-sym-doc
                              sym (eldoc-docstring-first-line doc)))
                   (eldoc-last-data-store sym doc 'variable)))
-           doc))))
+	     doc)))))
 
 (defun eldoc-last-data-store (symbol doc type)
   (aset eldoc-last-data 0 symbol)

-- 
John Paul Wallington

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-01-02 23:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-02 23:52 bad checkdoc/eldoc interaction John Paul Wallington

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).