unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* simple improvements to make-mode.el
@ 2002-10-30  1:31 Robert W Anderson
  2002-10-30 21:57 ` Kim F. Storm
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Robert W Anderson @ 2002-10-30  1:31 UTC (permalink / raw)


In make-mode.el, the definition of makefile-macroassign-regex misses
macro assignments that prepend the keyword "export".  font-lock then
misses them for colorization.

In addition, it seems natural to include in font-lock-keyword-face
additional keywords beyond include directives and conditionals, to
include for example all of GNU make's keywords (foreach, etc.)

What is the proper procedure for submitting these extensions?  diff
against CVS HEAD and mail to the list?

Thanks,
Bob Anderson

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: simple improvements to make-mode.el
  2002-10-30  1:31 simple improvements to make-mode.el Robert W Anderson
@ 2002-10-30 21:57 ` Kim F. Storm
  2002-10-30 21:59 ` Kim F. Storm
  2002-10-31 17:25 ` Richard Stallman
  2 siblings, 0 replies; 4+ messages in thread
From: Kim F. Storm @ 2002-10-30 21:57 UTC (permalink / raw)
  Cc: emacs-devel

Robert W Anderson <rwa@alumni.princeton.edu> writes:

> In make-mode.el, the definition of makefile-macroassign-regex misses
> macro assignments that prepend the keyword "export".  font-lock then
> misses them for colorization.
> 
> In addition, it seems natural to include in font-lock-keyword-face
> additional keywords beyond include directives and conditionals, to
> include for example all of GNU make's keywords (foreach, etc.)
> 
> What is the proper procedure for submitting these extensions?  diff
> against CVS HEAD and mail to the list?

This question pops up time and again!

Maybe we could add a test to the makefile, so that doing 'make' if
e.g. lisp/files.elc does not exist, it does 'cat INSTALL_CVS'
and exits?


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: simple improvements to make-mode.el
  2002-10-30  1:31 simple improvements to make-mode.el Robert W Anderson
  2002-10-30 21:57 ` Kim F. Storm
@ 2002-10-30 21:59 ` Kim F. Storm
  2002-10-31 17:25 ` Richard Stallman
  2 siblings, 0 replies; 4+ messages in thread
From: Kim F. Storm @ 2002-10-30 21:59 UTC (permalink / raw)
  Cc: emacs-devel


Sorry, the reply I just sent was related to another mail.
Please disregard!

Robert W Anderson <rwa@alumni.princeton.edu> writes:

> In make-mode.el, the definition of makefile-macroassign-regex misses
> macro assignments that prepend the keyword "export".  font-lock then
> misses them for colorization.
> 
> In addition, it seems natural to include in font-lock-keyword-face
> additional keywords beyond include directives and conditionals, to
> include for example all of GNU make's keywords (foreach, etc.)
> 
> What is the proper procedure for submitting these extensions?  diff
> against CVS HEAD and mail to the list?

This question pops up time and again!

Maybe we could add a test to the makefile, so that doing 'make' if
e.g. lisp/files.elc does not exist, it does 'cat INSTALL_CVS'
and exits?


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: simple improvements to make-mode.el
  2002-10-30  1:31 simple improvements to make-mode.el Robert W Anderson
  2002-10-30 21:57 ` Kim F. Storm
  2002-10-30 21:59 ` Kim F. Storm
@ 2002-10-31 17:25 ` Richard Stallman
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2002-10-31 17:25 UTC (permalink / raw)
  Cc: emacs-devel

    What is the proper procedure for submitting these extensions?  diff
    against CVS HEAD and mail to the list?

That is a fine method.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-10-31 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-30  1:31 simple improvements to make-mode.el Robert W Anderson
2002-10-30 21:57 ` Kim F. Storm
2002-10-30 21:59 ` Kim F. Storm
2002-10-31 17:25 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).