unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: New and improved patch for Windows implementation of play-sound-internal
Date: Wed, 30 Oct 2002 12:16:43 -0500	[thread overview]
Message-ID: <E186wSR-0002op-00@fencepost.gnu.org> (raw)
In-Reply-To: <001101c27f0b$e7d63c20$6401a8c0@GODDESS> (Bkey1@tampabay.rr.com)

    +  memset(sz_cmd_buf,0,sizeof(sz_cmd_buf));=0A=
    +  memset(sz_ret_buf,0,sizeof(sz_ret_buf));=0A=
    +  strcpy(sz_cmd_buf,"play GNUEmacs_PlaySound_Device wait");=0A=

Please put a space after each comma, and outside of parentheses
(unless they are inside other parentheses):

    +  memset (sz_cmd_buf, 0, sizeof (sz_cmd_buf));=0A=
    +  memset (sz_ret_buf, 0, sizeof (sz_ret_buf));=0A=
    +  strcpy (sz_cmd_buf, "play GNUEmacs_PlaySound_Device wait");=0A=

Please put spaces around binary operators such as !=.

+  if (mci_error!=0)

should be

+  if (mci_error != 0)

      reply	other threads:[~2002-10-30 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-29  5:27 New and improved patch for Windows implementation of play-sound-internal Ben Key
2002-10-30 17:16 ` Richard Stallman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E186wSR-0002op-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).