From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: New and improved patch for Windows implementation of play-sound-internal
Date: Wed, 30 Oct 2002 12:16:43 -0500
Sender: emacs-devel-admin@gnu.org
Message-ID: <E186wSR-0002op-00@fencepost.gnu.org>
References: <001101c27f0b$e7d63c20$6401a8c0@GODDESS>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
X-Trace: main.gmane.org 1036002200 4610 80.91.224.249 (30 Oct 2002 18:23:20 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 30 Oct 2002 18:23:20 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 186xT1-00014H-00
	for <emacs-devel@main.gmane.org>; Wed, 30 Oct 2002 19:21:23 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 186xYE-0001Un-00
	for <emacs-devel@quimby.gnus.org>; Wed, 30 Oct 2002 19:26:46 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 186xQe-00055g-00; Wed, 30 Oct 2002 13:18:56 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 186wSW-0006PY-00
	for emacs-devel@gnu.org; Wed, 30 Oct 2002 12:16:48 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 186wSS-0006FI-00
	for emacs-devel@gnu.org; Wed, 30 Oct 2002 12:16:46 -0500
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 186wSR-0006Er-00
	for emacs-devel@gnu.org; Wed, 30 Oct 2002 12:16:43 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10)
	id 186wSR-0002op-00; Wed, 30 Oct 2002 12:16:43 -0500
Original-To: Bkey1@tampabay.rr.com
In-reply-to: <001101c27f0b$e7d63c20$6401a8c0@GODDESS> (Bkey1@tampabay.rr.com)
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:8959
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8959

    +  memset(sz_cmd_buf,0,sizeof(sz_cmd_buf));=0A=
    +  memset(sz_ret_buf,0,sizeof(sz_ret_buf));=0A=
    +  strcpy(sz_cmd_buf,"play GNUEmacs_PlaySound_Device wait");=0A=

Please put a space after each comma, and outside of parentheses
(unless they are inside other parentheses):

    +  memset (sz_cmd_buf, 0, sizeof (sz_cmd_buf));=0A=
    +  memset (sz_ret_buf, 0, sizeof (sz_ret_buf));=0A=
    +  strcpy (sz_cmd_buf, "play GNUEmacs_PlaySound_Device wait");=0A=

Please put spaces around binary operators such as !=.

+  if (mci_error!=0)

should be

+  if (mci_error != 0)