Re: `fancy-splash-frame' query

[John Paul Wallington <jpw@shootybangbang.com>]

I wrote:

> Presently, picking "About Emacs" from the Help menu when I have
> multiple frames puts the splash screen in a different frame from the
> selected one.
> 
> Here is a `fancy-splash-frame' that checks the selected frame first
> and returns the first suitable frame rather than the last.
> 
> Is the present behaviour problematic?  Is this version okay (I have
> only tested it lightly) ?

Oh boy!  Sorry, that version stunk; it would lose if it ran out of
frames.  I am a degenerate for testing it so lightly.

Here's an alternative...

2002-07-31  John Paul Wallington  <jpw@shootybangbang.com>

	* startup.el (fancy-splash-frame): Check selected frame last.

Index: startup.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/startup.el,v
retrieving revision 1.302
diff -u -r1.302 startup.el
--- startup.el	14 Jul 2002 15:29:56 -0000	1.302
+++ startup.el	31 Jul 2002 01:29:26 -0000
@@ -1306,7 +1306,7 @@
 use the fancy splash screen, but if we do use it,
 we put it on this frame."
   (let (chosen-frame)
-    (dolist (frame (frame-list))
+    (dolist (frame (append (frame-list) (list (selected-frame))))
       (if (and (frame-visible-p frame)
 	       (not (window-minibuffer-p (frame-selected-window frame))))
 	  (setq chosen-frame frame)))

-- 
John Paul Wallington