`fancy-splash-frame' query

[John Paul Wallington <jpw@shootybangbang.com>]

Hi!

Presently, picking "About Emacs" from the Help menu when I have
multiple frames puts the splash screen in a different frame from the
selected one.

Here is a `fancy-splash-frame' that checks the selected frame first
and returns the first suitable frame rather than the last.

Is the present behaviour problematic?  Is this version okay (I have
only tested it lightly) ?


2002-07-31  John Paul Wallington  <jpw@shootybangbang.com>

	* startup.el (fancy-splash-frame): Check selected frame first.
	Use `visible-frame-list' instead of `frame-list'.  Return first
	suitable frame instead of last.

Index: startup.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/startup.el,v
retrieving revision 1.302
diff -u -r1.302 startup.el
*** startup.el	14 Jul 2002 15:29:56 -0000	1.302
--- startup.el	31 Jul 2002 00:15:55 -0000
***************
*** 1305,1315 ****
  Returning non-nil does not mean we should necessarily
  use the fancy splash screen, but if we do use it,
  we put it on this frame."
!   (let (chosen-frame)
!     (dolist (frame (frame-list))
!       (if (and (frame-visible-p frame)
! 	       (not (window-minibuffer-p (frame-selected-window frame))))
! 	  (setq chosen-frame frame)))
      chosen-frame))
  
  (defun use-fancy-splash-screens-p ()
--- 1305,1317 ----
  Returning non-nil does not mean we should necessarily
  use the fancy splash screen, but if we do use it,
  we put it on this frame."
!   (let ((frames (cons (selected-frame) (visible-frame-list)))
! 	chosen-frame)
!     (while (not chosen-frame)
!       (let ((frame (pop frames)))
! 	(if (and (frame-visible-p frame)
! 		 (not (window-minibuffer-p (frame-selected-window frame))))
! 	    (setq chosen-frame frame))))
      chosen-frame))
  
  (defun use-fancy-splash-screens-p ()


-- 
John Paul Wallington