unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Copley <rcopley@gmail.com>
To: Drew Adams <drew.adams@oracle.com>,
	Philipp Stephani <p.stephani2@gmail.com>,
	 Emacs Development <emacs-devel@gnu.org>,
	Philipp Stephani <phst@google.com>
Subject: Re: [PATCH] Add new function to test whether a key is present in a hash table.
Date: Sun, 18 Feb 2018 14:29:33 +0000	[thread overview]
Message-ID: <CAPM58oh+1TO4WCGGA94Zee1EYic=xWwNK+uStTpTDD-sROJNyw@mail.gmail.com> (raw)
In-Reply-To: <m237215svl.fsf@newartisans.com>

On 16 February 2018 at 06:51, John Wiegley <johnw@gnu.org> wrote:
>>>>>> "DA" == Drew Adams <drew.adams@oracle.com> writes:
>
> DA> 2. The function name should have `key' in it, I think. Suggestion:
> DA> `hash-table-contains-key-p' or even just `hash-table-key-p'.
>
> It seems a bit strange that the name isn't something like "hashash", since
> knowing "puthash" and "gethash" would never help you guess
> hash-table-contains-key-p.

Or "testhash"? And maybe "tryhash" or "try-gethash" for a function that
returns a cons or "slot" of some kind.



  reply	other threads:[~2018-02-18 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<20180215203406.64372-1-phst@google.com>
2018-02-15 22:08 ` [PATCH] Add new function to test whether a key is present in a hash table Drew Adams
2018-02-15 23:35   ` Eric Abrahamsen
2018-02-16  6:51   ` John Wiegley
2018-02-18 14:29     ` Richard Copley [this message]
2018-02-19  6:02       ` John Wiegley
2018-02-19 17:26     ` Drew Adams
2018-02-15 20:34 Philipp Stephani
2018-02-15 22:03 ` Clément Pit-Claudel
2019-04-19 17:33   ` Philipp Stephani
2018-02-15 22:59 ` Stefan Monnier
2018-02-16  1:03   ` Drew Adams
2018-02-16  1:59     ` Stefan Monnier
2018-02-16  2:50       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM58oh+1TO4WCGGA94Zee1EYic=xWwNK+uStTpTDD-sROJNyw@mail.gmail.com' \
    --to=rcopley@gmail.com \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).