From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add new function to test whether a key is present in a hash table. Date: Sun, 18 Feb 2018 14:29:33 +0000 Message-ID: References: <20180215203406.64372-1-phst@google.com> <2ce9b5db-b17d-415c-8dc6-6046a31269be@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1518964148 24384 195.159.176.226 (18 Feb 2018 14:29:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Feb 2018 14:29:08 +0000 (UTC) To: Drew Adams , Philipp Stephani , Emacs Development , Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 18 15:29:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enPxf-00061q-CS for ged-emacs-devel@m.gmane.org; Sun, 18 Feb 2018 15:29:03 +0100 Original-Received: from localhost ([::1]:33014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enPzh-0005Jm-Bo for ged-emacs-devel@m.gmane.org; Sun, 18 Feb 2018 09:31:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enPyg-0005Fz-Cd for emacs-devel@gnu.org; Sun, 18 Feb 2018 09:30:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enPyf-0000mJ-I0 for emacs-devel@gnu.org; Sun, 18 Feb 2018 09:30:06 -0500 Original-Received: from mail-ot0-x229.google.com ([2607:f8b0:4003:c0f::229]:42418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enPyf-0000m4-DT for emacs-devel@gnu.org; Sun, 18 Feb 2018 09:30:05 -0500 Original-Received: by mail-ot0-x229.google.com with SMTP id a7so6524595otk.9 for ; Sun, 18 Feb 2018 06:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=8YcS1P6xV3S4yy9NPEuMMG3y7xcB9zn0q+CUvYRsIu8=; b=ta9AqdEkW+kA/DqRVQV7Gtvw8SF6R6rh7BWtoqbyTRByfrEh2xeYFP16lEhbgkqDof e6NOgvmp7GrRGW1JF8PLdAKwlCpGJltNgpd8jb8SAtNqjoHzHke5aBuOt0nXMHcoZN62 HAJjSxsrvqm4dWFihvMNv3QDwC32BejntGcgd7xESUet2+3xQgBvZq4UdvYXCu00rw3e Y8Klml+WqezO2FkHfXm9nH5IIQzg62t2NaQMHiGHMjUTqyC6hGzLMRY3MZ8FmZieqjVW tfiG1WeH5WbqBQes5PGjwJan4BjBf9nrYRV2VRJ54HLrF7FzG8V/q6dXvMF6fnZxuQx/ VpFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=8YcS1P6xV3S4yy9NPEuMMG3y7xcB9zn0q+CUvYRsIu8=; b=AfOW52qhC+SRjHfMkgrOQH9wQ4jJ8fqKqRR9Dm3w9wf0WOjVFbUg+2+vt3Dfc+44g0 Gj2JxP3215UR+pnpKUGMS2g12ypEOuoxCfUpqgGb44FoCaU44iWT0koWnuO5QLDnL6Cq yXl9zJ3cLuAzYl0c6DZnYZe2/0F4bucwwYk860dXT8wVUGi75Mww1gUT1x6nEfWz3Rrb mS2Mi515RwihCuO6FMm8Pv057F9GUJB+lefIxljLPu7Jue9MTGn0eHPx/xV9++Jm+yLJ A2+u3fErsbxZGZKl1QE5fY8MtYWw7Ujl1Ig0o1aKwvBDABv4pu/Sf26vUEjGCD4/MLoO +CwA== X-Gm-Message-State: APf1xPDck69aVBLHFxnYbMBp/OuGJAT9f8zA9yAwK5XNCkhmYW76XPXW 8xnrlhV1edAw3Sg3QQ0677MN0tdQTi+X1/yMzO0= X-Google-Smtp-Source: AH8x225udhOvQmu4a3JANYridqy9vYwVF5F+iN3kdDkymnY+LuuR5u7hJK3Zjrr4j887hLqRaabU7/mTMk7ln0DX9jY= X-Received: by 10.157.24.28 with SMTP id b28mr9307780ote.356.1518964204268; Sun, 18 Feb 2018 06:30:04 -0800 (PST) Original-Received: by 10.157.68.215 with HTTP; Sun, 18 Feb 2018 06:29:33 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222874 Archived-At: On 16 February 2018 at 06:51, John Wiegley wrote: >>>>>> "DA" == Drew Adams writes: > > DA> 2. The function name should have `key' in it, I think. Suggestion: > DA> `hash-table-contains-key-p' or even just `hash-table-key-p'. > > It seems a bit strange that the name isn't something like "hashash", since > knowing "puthash" and "gethash" would never help you guess > hash-table-contains-key-p. Or "testhash"? And maybe "tryhash" or "try-gethash" for a function that returns a cons or "slot" of some kind.