[PATCH] Add comint-clear-buffer

[PATCH] Add comint-clear-buffer

[Bozhidar Batsov]

[-- Attachment #1.1: Type: text/plain, Size: 178 bytes --]

Any objections to the attached patched?

Clearing the entire comint buffer is a pretty common functionality often
added in modes based on comint and I'd like to see it built-in.

[-- Attachment #1.2: Type: text/html, Size: 227 bytes --]

[-- Attachment #2: 0001-Add-comint-clear-buffer.patch --]
[-- Type: application/octet-stream, Size: 1268 bytes --]

From 042030b2b71377d15ef71f41e7a443967319bf8c Mon Sep 17 00:00:00 2001
From: Bozhidar Batsov <bozhidar@batsov.com>
Date: Sun, 22 Feb 2015 08:01:08 +0200
Subject: [PATCH] Add comint-clear-buffer

---
 lisp/comint.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/comint.el b/lisp/comint.el
index 30c4dda..30aece1 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -472,6 +472,7 @@ executed once when the buffer is created."
     (define-key map "\C-c\C-\\"   'comint-quit-subjob)
     (define-key map "\C-c\C-m" 	  'comint-copy-old-input)
     (define-key map "\C-c\C-o" 	  'comint-delete-output)
+    (defile-key map "\C-c\M-o"    'comint-clear-buffer)
     (define-key map "\C-c\C-r" 	  'comint-show-output)
     (define-key map "\C-c\C-e" 	  'comint-show-maximum-output)
     (define-key map "\C-c\C-l" 	  'comint-dynamic-list-input-ring)
@@ -2428,6 +2429,11 @@ Sets mark to the value of point when this command is run."
 	   (goto-char (field-beginning pos))
 	   (set-window-start (selected-window) (point))))))
 
+(defun comint-clear-buffer ()
+  "Clear the comint buffer."
+  (interactive)
+  (let ((comint-buffer-maximum-size 0))
+    (comint-truncate-buffer)))
 
 (defun comint-interrupt-subjob ()
   "Interrupt the current subjob.
-- 
2.2.2

Re: [PATCH] Add comint-clear-buffer

[Stefan Monnier]

> Any objections to the attached patched?
> Clearing the entire comint buffer is a pretty common functionality often
> added in modes based on comint and I'd like to see it built-in.

I haven't noticed it being added to derived modes, but it sounds like
useful functionality: I typically use M-x erase-buffer, but keeping this
loses the current input&prompt, so a dedicated command sounds better.

IOW: go ahead (as for the chosen key-binding, it sounds completely
arbitrary, but I don't have a better suggestion).


        Stefan

Re: [PATCH] Add comint-clear-buffer

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

Thanks!

Regarding the keybinding - it was chosen because of `C-c C-o` and a similar
command in SLIME and CIDER bound to `C-c M-o`.

On 22 February 2015 at 23:23, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > Any objections to the attached patched?
> > Clearing the entire comint buffer is a pretty common functionality often
> > added in modes based on comint and I'd like to see it built-in.
>
> I haven't noticed it being added to derived modes, but it sounds like
> useful functionality: I typically use M-x erase-buffer, but keeping this
> loses the current input&prompt, so a dedicated command sounds better.
>
> IOW: go ahead (as for the chosen key-binding, it sounds completely
> arbitrary, but I don't have a better suggestion).
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1241 bytes --]