Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121)

Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121)

[Michael Albinus]

npostavs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org (Noam Postavsky)
writes:

Hi Noam,

> --- a/packages/debbugs/debbugs-gnu.el
> +++ b/packages/debbugs/debbugs-gnu.el
> @@ -1592,7 +1592,9 @@ removed instead."
>             current-prefix-arg
>             (when (derived-mode-p 'message-mode)
>               (current-buffer)))))
> -  (let* ((status (debbugs-gnu-current-status))
> +  (let* ((status (or (debbugs-gnu-current-status)
> +                     (gethash bugid debbugs-cache-data)
> +                     (debbugs-get-status bugid)))
>           (version
>            (if (and
>                 (member message '("close" "done"

Yesterday evening I was a little bit tired, so I didn't check precisely.

`debbugs-get-status' consults the cache first, so there is no reason to
call `gethash' explicitly. Furthermore, `debbugs-get-status' checks
whether cache entries have been expired, and refuses them.

That's why `gethash' isn't called anywhere else in debbugs-gnu.el; it is
an implementation detail of debbugs.el we shouldn't care.

Best regards, Michael.

Re: [elpa] master 1a6a4a3: Search further if d-g-cur-status is nil (Bug#35121)

[Noam Postavsky]

On Thu, 4 Apr 2019 at 03:08, Michael Albinus <michael.albinus@gmx.de> wrote:

> > -  (let* ((status (debbugs-gnu-current-status))
> > +  (let* ((status (or (debbugs-gnu-current-status)
> > +                     (gethash bugid debbugs-cache-data)
> > +                     (debbugs-get-status bugid)))

> Yesterday evening I was a little bit tired, so I didn't check precisely.
>
> `debbugs-get-status' consults the cache first, so there is no reason to
> call `gethash' explicitly. Furthermore, `debbugs-get-status' checks
> whether cache entries have been expired, and refuses them.

Hmm, I had somehow thought it wasn't, but it must have been me not
realizing that a bug status wasn't cached or something.  And I was
missing the call to 'car' on the result of debbugs-get-status (I think
I had even noticed that while testing, but somehow I didn't fix it in
the pushed version). Anyway, should all be fixed now.

[1: 3355f3b2f]: 2019-04-04 07:01:41 -0400
  Fix previous change
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3355f3b2f0fd5f988b5b1127392e7d999c094b0e