* Re: master 73f37da: Disable undo in the process buffers of a JSONRPC connection
[not found] ` <20191213163544.A0FEF2111A@vcs0.savannah.gnu.org>
@ 2019-12-13 18:28 ` Stefan Monnier
2019-12-13 21:09 ` João Távora
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-12-13 18:28 UTC (permalink / raw)
To: emacs-devel; +Cc: João Távora
Hi João,
> Disable undo in the process buffers of a JSONRPC connection
> + (buffer-disable-undo)
> (set-marker (process-mark proc) (point-min))
> (let ((inhibit-read-only t)) (erase-buffer) (read-only-mode t) proc))
> + (with-current-buffer stderr
> + (buffer-disable-undo))
Assuming those buffers are only used internally and are not intended to
be displayed to the end-user (other than for debugging purposes), then
using buffer names with a leading space should take care of this
(undo is disabled by default in those buffers).
If you're already using a leading space in those buffers's names, then
I wonder how/why their undo was enabled in the first place.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 73f37da: Disable undo in the process buffers of a JSONRPC connection
2019-12-13 18:28 ` master 73f37da: Disable undo in the process buffers of a JSONRPC connection Stefan Monnier
@ 2019-12-13 21:09 ` João Távora
0 siblings, 0 replies; 2+ messages in thread
From: João Távora @ 2019-12-13 21:09 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
Hi Stefan,
They are indeed intended to be seen by the user. They hold important
communications between server and client, and I ask users to post their
contents when making Eglot bug reports.
Well I suppose the stdout one less useful than stderr.
And this is more of an LSP requirement than an jsonrpc one. I could
theoretically make Eglot tell. Jsonrpc to promote the buffer's visibility,
but that seems like overkill right now.
João
On Fri, Dec 13, 2019, 19:28 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Hi João,
>
> > Disable undo in the process buffers of a JSONRPC connection
> > + (buffer-disable-undo)
> > (set-marker (process-mark proc) (point-min))
> > (let ((inhibit-read-only t)) (erase-buffer) (read-only-mode t)
> proc))
> > + (with-current-buffer stderr
> > + (buffer-disable-undo))
>
> Assuming those buffers are only used internally and are not intended to
> be displayed to the end-user (other than for debugging purposes), then
> using buffer names with a leading space should take care of this
> (undo is disabled by default in those buffers).
>
> If you're already using a leading space in those buffers's names, then
> I wonder how/why their undo was enabled in the first place.
>
>
> Stefan
>
>
[-- Attachment #2: Type: text/html, Size: 1889 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-13 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191213163543.19521.86114@vcs0.savannah.gnu.org>
[not found] ` <20191213163544.A0FEF2111A@vcs0.savannah.gnu.org>
2019-12-13 18:28 ` master 73f37da: Disable undo in the process buffers of a JSONRPC connection Stefan Monnier
2019-12-13 21:09 ` João Távora
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).