From: "João Távora" <joaotavora@gmail.com>
To: Pip Cet <pipcet@gmail.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: 31395511: "Don’t attempt to modify constant strings"
Date: Thu, 4 Jun 2020 00:48:34 +0100 [thread overview]
Message-ID: <CALDnm51D1EoPbTAnj=2OYL+bUTyXtCVn87zxb8QqbzF5ksiFOQ@mail.gmail.com> (raw)
In-Reply-To: <87lfl36abx.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Wed, Jun 3, 2020 at 11:42 PM Pip Cet <pipcet@gmail.com> wrote:
> João Távora <joaotavora@gmail.com> writes:
>
> I think you want
> (defun sly-make-action-button (label action &rest props)
> (apply #'sly--make-text-button
> label nil :type 'sly-action
> 'action action
> 'mouse-action action
> props))
>
> instead, since the new function returns a copy of label rather than the
> string passed in.
By itself, that doesn't work. I have the same problem.
I think I'd rather this previous behavior were retained, or at least
achievable by request. I haven't touched this code in a long
I don't know what else might depend on it.
I don't care about < 24.4 compatibility, if that helps
João
[-- Attachment #2: Type: text/html, Size: 1326 bytes --]
next prev parent reply other threads:[~2020-06-03 23:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 21:52 31395511: "Don’t attempt to modify constant strings" João Távora
2020-06-03 22:41 ` Paul Eggert
2020-06-03 22:52 ` Pip Cet
2020-06-03 23:20 ` Paul Eggert
2020-06-03 23:20 ` Basil L. Contovounesios
2020-06-03 22:41 ` Pip Cet
2020-06-03 23:08 ` Basil L. Contovounesios
2020-06-03 23:31 ` Basil L. Contovounesios
2020-06-03 23:48 ` João Távora [this message]
2020-06-04 0:43 ` Paul Eggert
2020-06-04 1:19 ` Paul Eggert
2020-06-04 7:26 ` Pip Cet
2020-06-04 11:11 ` Basil L. Contovounesios
2020-06-04 19:46 ` Paul Eggert
2020-06-04 20:25 ` João Távora
2020-06-04 20:29 ` Paul Eggert
2020-06-04 21:21 ` Drew Adams
2020-06-04 20:43 ` Pip Cet
2020-06-04 21:27 ` Stefan Monnier
2020-06-04 21:42 ` Pip Cet
2020-06-04 23:10 ` Paul Eggert
2020-06-05 2:09 ` Clément Pit-Claudel
2020-06-05 6:44 ` Paul Eggert
2020-06-05 12:44 ` Stefan Monnier
2020-06-05 17:01 ` Drew Adams
2020-06-05 9:48 ` Pip Cet
2020-06-05 18:37 ` Paul Eggert
2020-06-04 22:33 ` Basil L. Contovounesios
2020-06-05 15:25 ` João Távora
2020-06-05 17:14 ` Dmitry Gutov
2020-06-05 23:19 ` João Távora
2020-06-05 23:32 ` Dmitry Gutov
2020-06-06 1:34 ` FW: " Drew Adams
2020-06-06 0:23 ` Drew Adams
2020-06-06 1:43 ` Paul Eggert
2020-06-06 4:06 ` Richard Stallman
2020-06-06 11:41 ` João Távora
2020-06-06 11:47 ` João Távora
2020-06-04 4:38 ` Pip Cet
2020-06-04 9:31 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51D1EoPbTAnj=2OYL+bUTyXtCVn87zxb8QqbzF5ksiFOQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).