From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: =?UTF-8?Q?Re=3A_31395511=3A_=22Don=E2=80=99t_attempt_to_modify_constant_st?= =?UTF-8?Q?rings=22?= Date: Thu, 4 Jun 2020 00:48:34 +0100 Message-ID: References: <871rmvn7ge.fsf@gmail.com> <87lfl36abx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000041927905a736ab15" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37262"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Paul Eggert , emacs-devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 01:49:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgd8H-0009b5-Hd for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 01:49:17 +0200 Original-Received: from localhost ([::1]:52740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgd8G-0000Ul-KO for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 19:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgd7o-0008VL-Pb for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:48:48 -0400 Original-Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]:33231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgd7o-0006sS-00 for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:48:48 -0400 Original-Received: by mail-io1-xd29.google.com with SMTP id k18so4370894ion.0 for ; Wed, 03 Jun 2020 16:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e4BLgDSntkul2HB+nEVg6UMCNIpe3g7Ku8qqpeRJqao=; b=dK67VkLYogS8Lo9h/WI1JPvlfwC5wNrbuveLimmnWGYKFiK/BhZiIVkcuXuRbZNAHz pHMawdFNm01E250b53xMFydtrkA8mt8xfwQoj4GXb8jK88RlwEc9hEQ2rzJyfwVar1Pb B3AQsiToSDD4rGTFSWrOIIJS1koKF3khUONLpeuWDLD6Tgi/chwcDF9icGWzVvyFSic3 pDgTT6k10XnatyEodF7Juu3dFZOMPDfwehhMEJ0HrusirS7t23ZpoTn9ulLWxaZ/IaJV EVkAtKWdNyEKIn44zJ5iLehkLZ8/PrXZI6Nqn3TalzBRPQFr1W+iwMTaCCa2j4Dck+rL gvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e4BLgDSntkul2HB+nEVg6UMCNIpe3g7Ku8qqpeRJqao=; b=Co8pFwNYdM1RYg6kOhVPshilbyvf7/gOBhryZmJQCzYDXWSu0LqBAEwJfOTuYfuPbS IqAwVaghIw99FphL+riipNDeawpSz114tv9M6SbO0thJS9ljakgK9NR6jz2cVYFJIBAk cjBVz2ynwP2yFJ3RfDZlzgy0fbjGPpqzNADv+239x3Eon6mKZ7C+7j9Jh/rkTIzNGtiZ 25jSr6UMQ7vxe2xT9RpkT1SOGN7OOPgZ0opbX2K5BHjx3Grx/AhhQEapZwrDxCU2AX8D UtTTe0TD2wbcJXvPIJ9zSVXl2m7xhUA1NK+FoTloQVLFb+pirFYMur/GJO2cXGOmcO83 MX7g== X-Gm-Message-State: AOAM531BIfg32YPLAjrxBmP6t6UWzGvWPFmF1A1BOpenAsAyvbsshi5p sWVAUwAHAH8Wwxz68hvYYIhndhQB/UkEUAyim0w= X-Google-Smtp-Source: ABdhPJyLy+g1oUsRku8fT6hjclelUcXYuqkZV/hbgZBNMtaUT+efXOCn98jOWGlS0fxsW2Iy7wsCjP1H08zRtvc2598= X-Received: by 2002:a5d:8e14:: with SMTP id e20mr1975977iod.156.1591228126826; Wed, 03 Jun 2020 16:48:46 -0700 (PDT) In-Reply-To: <87lfl36abx.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=joaotavora@gmail.com; helo=mail-io1-xd29.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251838 Archived-At: --00000000000041927905a736ab15 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 3, 2020 at 11:42 PM Pip Cet wrote: > Jo=C3=A3o T=C3=A1vora writes: > > I think you want > (defun sly-make-action-button (label action &rest props) > (apply #'sly--make-text-button > label nil :type 'sly-action > 'action action > 'mouse-action action > props)) > > instead, since the new function returns a copy of label rather than the > string passed in. By itself, that doesn't work. I have the same problem. I think I'd rather this previous behavior were retained, or at least achievable by request. I haven't touched this code in a long I don't know what else might depend on it. I don't care about < 24.4 compatibility, if that helps Jo=C3=A3o --00000000000041927905a736ab15 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jun 3, 2020 at 11:42 PM Pip Cet <pipcet@gmail.com> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:
I think you want
(defun sly-make-action-button (label action &rest props)
=C2=A0 (apply #'sly--make-text-button
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0label nil :type 'sly-action
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'action action
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'mouse-action action
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0props))

instead, since the new function returns a copy of label rather than the
string passed in.

By itself, that doesn'= ;t work.=C2=A0 I have the same problem.

I think I&= #39;d rather this previous behavior were retained, or at least
ac= hievable by request. I haven't touched this code in a long
I don't know what else might depend on it.

= I don't care about < 24.4 compatibility, if that helps
Jo=C3=A3o


--00000000000041927905a736ab15--