* [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5
@ 2019-08-29 17:40 Patrick J. LoPresti
2019-08-30 4:01 ` Richard Stallman
2019-08-30 8:57 ` Eli Zaretskii
0 siblings, 2 replies; 3+ messages in thread
From: Patrick J. LoPresti @ 2019-08-29 17:40 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Not sure whether anyone cares about supporting ancient Linux versions...
But RHEL 5.x shipped with librsvg2 2.16.1, which did not provide the
LIBSRVG_CHECK_VERSION macro.
Simple patch below allows Emacs 26.3 to compile on RHEL/CentOS 5.
- Pat
diff -u -r emacs-26.3-orig/src/image.c emacs-26.3/src/image.c
--- emacs-26.3-orig/src/image.c 2019-06-12 03:50:42.000000000 -0700
+++ emacs-26.3/src/image.c 2019-08-29 10:13:13.000000000 -0700
@@ -9313,9 +9313,11 @@
#if GNUC_PREREQ (4, 6, 0)
#pragma GCC diagnostic push
#endif
+ #if defined(LIBSRVG_CHECK_VERSION)
#if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0)
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
+ #endif
/* Parse the contents argument and fill in the rsvg_handle. */
rsvg_handle_write (rsvg_handle, (unsigned char *) contents, size, &err);
[-- Attachment #2: Type: text/html, Size: 1058 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5
2019-08-29 17:40 [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5 Patrick J. LoPresti
@ 2019-08-30 4:01 ` Richard Stallman
2019-08-30 8:57 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2019-08-30 4:01 UTC (permalink / raw)
To: Patrick J. LoPresti; +Cc: emacs-devel
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> Not sure whether anyone cares about supporting ancient Linux versions...
It looks like this case concerns old versions of GNU/Linux distros,
rather than versions of Linux as such.
See https://gnu.org/gnu/linux-and-gnu.html and
https://gnu.org/gnu/gnu-linux-faq.html, plus the history in
https://gnu.org/gnu/the-gnu-project.html.
Thanks for fixing the bug.
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5
2019-08-29 17:40 [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5 Patrick J. LoPresti
2019-08-30 4:01 ` Richard Stallman
@ 2019-08-30 8:57 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2019-08-30 8:57 UTC (permalink / raw)
To: Patrick J. LoPresti; +Cc: emacs-devel
> From: "Patrick J. LoPresti" <lopresti@gmail.com>
> Date: Thu, 29 Aug 2019 10:40:14 -0700
>
> Not sure whether anyone cares about supporting ancient Linux versions... But RHEL 5.x shipped with librsvg2
> 2.16.1, which did not provide the LIBSRVG_CHECK_VERSION macro.
Thanks, this issue is already fixed on the master branch. We don't
currently envision any further releases from the emacs-26 branch, so
the problem seems to fixed for all practical purposes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-30 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 17:40 [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5 Patrick J. LoPresti
2019-08-30 4:01 ` Richard Stallman
2019-08-30 8:57 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).