unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Corwin Brust <corwin@bru.st>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Sam Steingold <sds@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code
Date: Sat, 8 Jan 2022 11:40:29 -0600	[thread overview]
Message-ID: <CAJf-WoQdp3U1MxS=z+7Dwvv=tmP_6xzMHbR0Vif+mLuxhX-WcQ@mail.gmail.com> (raw)
In-Reply-To: <875yqu8xr8.fsf@gmx.de>

Hi Michael,

On Sat, Jan 8, 2022 at 2:54 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Sam Steingold <sds@gnu.org> writes:
>
> Tramp ought to use a different implementation:
>
> --8<---------------cut here---------------start------------->8---
> > -              (while (functionp auth-passwd)
> > -                (setq auth-passwd (funcall auth-passwd)))
> --8<---------------cut here---------------end--------------->8---
>
> I have no reference for the problem which has triggered this, all I've
> found is this ChangeLog entry:
>
> --8<---------------cut here---------------start------------->8---
> 2018-05-02  Michael Albinus  <michael.albinus@gmx.de>
>
>         * tramp.el: ...
>         (tramp-read-passwd): auth-source could return cascaded functions.
> --8<---------------cut here---------------end--------------->8---
>
> Perhaps it is better to use the loop as well in auth-info-password?

Looking at this patch last night I had the same idea  -- I don't see
any reason *not* to allow cascaded functions in all cases while not
allowing this for Tramp would actually be breaking.

FWIW, I too wondered if there was any bug related to this or if this
was simply pushed as an ad-hoc improvement across core/bundled
packages.

Warm regards,
Corwin



  reply	other threads:[~2022-01-08 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164158514200.7829.12726312320214416447@vcs2.savannah.gnu.org>
     [not found] ` <20220107195223.57DA2C0DA1B@vcs2.savannah.gnu.org>
2022-01-08  7:58   ` master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code Michael Albinus
2022-01-08 17:40     ` Corwin Brust [this message]
2022-01-08 17:48       ` Michael Albinus
2022-01-09 22:51     ` Sam Steingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJf-WoQdp3U1MxS=z+7Dwvv=tmP_6xzMHbR0Vif+mLuxhX-WcQ@mail.gmail.com' \
    --to=corwin@bru.st \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).