From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.devel Subject: Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code Date: Sat, 8 Jan 2022 11:40:29 -0600 Message-ID: References: <164158514200.7829.12726312320214416447@vcs2.savannah.gnu.org> <20220107195223.57DA2C0DA1B@vcs2.savannah.gnu.org> <875yqu8xr8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26606"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sam Steingold , Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 08 18:41:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6FiW-0006nn-2c for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Jan 2022 18:41:24 +0100 Original-Received: from localhost ([::1]:55046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6FiV-0008E1-3G for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Jan 2022 12:41:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6Fhs-0007V9-S4 for emacs-devel@gnu.org; Sat, 08 Jan 2022 12:40:44 -0500 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:34360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6Fhr-00075g-1c; Sat, 08 Jan 2022 12:40:44 -0500 Original-Received: by mail-ed1-f45.google.com with SMTP id u25so35427037edf.1; Sat, 08 Jan 2022 09:40:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yU+fGsEHF3cKSH8aWgR2cQhVRpcpciPkOlbHS9cdF2M=; b=fZFWibdr3AosOcA4ou+Hz3rLlr8+qM8hdssJMPGOopmikXQ6h3T0gJQp5mp4CROmIb I2OTYg6n/u3FMHrBltV2PF/sQqJaI0F3H0WfjVSgusL29D509+yDS278X/WwAWn+RXMA KdH270RzH3UAWCdAsnnzysRbNGdbFIamJboPe7lgpvjf//VtyVz+nzsG0XjZIXP6uwMD B0vnc/E2Ut5UHDCX+vb9qkBeq42yMio1wLQTgoBFyv08Za29eBLdr+YEHNFml37WOdJB sUGfGk6OHlgm1jwO/6jut1x1O5Wkwf0RbjvWNpFbhlkAZtMtkt7SuDDooIuEv0zfPh36 DYjA== X-Gm-Message-State: AOAM530/nbNGD8GPJPH6/2VYe84Yql0KugYwf/d7IDHD7+zt+Tc32Gvs gzRUndRKRISFJpxh866oPGE8JyRSVhDtDg1r5i8= X-Google-Smtp-Source: ABdhPJydim95icRG+dq8Z5Y1fDUSa2dDZ2HVgx+QRMDaYH6e2W/bPmqaXZ/SRaJ2EYfzlqluFmwwtO+6SDCVV2kZASg= X-Received: by 2002:a17:906:417:: with SMTP id d23mr2415382eja.469.1641663640904; Sat, 08 Jan 2022 09:40:40 -0800 (PST) In-Reply-To: <875yqu8xr8.fsf@gmx.de> Received-SPF: pass client-ip=209.85.208.45; envelope-from=mplscorwin@gmail.com; helo=mail-ed1-f45.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284479 Archived-At: Hi Michael, On Sat, Jan 8, 2022 at 2:54 AM Michael Albinus wrote: > > Sam Steingold writes: > > Tramp ought to use a different implementation: > > --8<---------------cut here---------------start------------->8--- > > - (while (functionp auth-passwd) > > - (setq auth-passwd (funcall auth-passwd))) > --8<---------------cut here---------------end--------------->8--- > > I have no reference for the problem which has triggered this, all I've > found is this ChangeLog entry: > > --8<---------------cut here---------------start------------->8--- > 2018-05-02 Michael Albinus > > * tramp.el: ... > (tramp-read-passwd): auth-source could return cascaded functions. > --8<---------------cut here---------------end--------------->8--- > > Perhaps it is better to use the loop as well in auth-info-password? Looking at this patch last night I had the same idea -- I don't see any reason *not* to allow cascaded functions in all cases while not allowing this for Tramp would actually be breaking. FWIW, I too wondered if there was any bug related to this or if this was simply pushed as an ad-hoc improvement across core/bundled packages. Warm regards, Corwin