unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] - Introduce reference to a new Emacs build target - NaCl
@ 2015-03-13 21:57 Pete Williamson
  2015-03-13 23:44 ` Michal Nazarewicz
  2015-03-14  0:28 ` Paul Eggert
  0 siblings, 2 replies; 12+ messages in thread
From: Pete Williamson @ 2015-03-13 21:57 UTC (permalink / raw)
  To: emacs-devel; +Cc: Michal Nazarewicz


[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]

I would like to request feedback on this patch for the emacs configure.ac
file.

As I mentioned in previous patch requests, I'm adding support for a new
build target, the chromium browser's Native Client (NaCl) platform.  We
have a patch for emacs working today (for some definitions of working ^_^)
in NaCl ports, and we would like to port the changes back to the emacs code
base.

Is this the right way to introduce a new build target?  Once this is
checked in, I have more changes for the config.ac file, but I wanted to
vette the approach with the good folks on this email list before proceeding.

For a preview of the other changes I hope to port to the configure.ac file,
here is a list of changes in our port today, I hope to port most or all of
these to the regular emacs code base in future patches.

--- a/configure
+++ b/configure
@@ -4631,6 +4631,10 @@ case "${canonical}" in
esac
;;

+ *-nacl )
+ opsys=nacl
+ ;;
+
## Intel 386 machines where we don't care about the manufacturer.
i[3456]86-*-* )
case "${canonical}" in
@@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \

test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
case "$opsys" in
+ nacl) CANNOT_DUMP=yes ;;
your-opsys-here) CANNOT_DUMP=yes ;;
esac

@@ -9828,6 +9833,7 @@ system_malloc=no
case "$opsys" in
## darwin ld insists on the use of malloc routines in the System framework.
darwin|sol2-10) system_malloc=yes ;;
+ nacl) system_malloc=yes ;;
esac

if test "${system_malloc}" = "yes"; then
@@ -15169,7 +15175,7 @@ esac
emacs_broken_SIGIO=no

case $opsys in
- hpux* | irix6-5 | openbsd | sol2* | unixware )
+ hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
emacs_broken_SIGIO=yes
;;

@@ -15277,7 +15283,7 @@ case $opsys in

;;

- gnu-linux | gnu-kfreebsd | freebsd | netbsd )
+ nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
if test "x$ac_cv_func_grantpt" = xyes; then

$as_echo "#define UNIX98_PTYS 1" >>confdefs.h
@@ -15430,7 +15436,7 @@ if test $emacs_glibc = yes; then
emacs_pending_output=unknown

case $opsys in
- gnu | gnu-linux | gnu-kfreebsd )
+ nacl | gnu | gnu-linux | gnu-kfreebsd )
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending
output formalism" >&5
$as_echo_n "checking for style of pending output formalism... " >&6; }
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
@@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=
ORDINARY_LINK=
case "$opsys" in
## gnu: GNU needs its own crt0.
- aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY_LINK=yes
;;
+ nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
ORDINARY_LINK=yes ;;

## On post 1.3 releases of NetBSD, gcc -nostdlib also clears the
## library search parth, i.e. it won't search /usr/lib for libc and Thanks!

[-- Attachment #1.2: Type: text/html, Size: 13969 bytes --]

[-- Attachment #2: 0001-Add-NaCl-to-list-of-supported-OSs.patch --]
[-- Type: text/x-patch, Size: 1301 bytes --]

From cd6ed4f967f17469effe552607b014e0c36fd0e1 Mon Sep 17 00:00:00 2001
From: Pete Williamson <petewil@chromium.org>
Date: Fri, 13 Mar 2015 11:56:36 -0700
Subject: [PATCH] Add NaCl to list of supported OSs

This is the first part of adding support for the NativeClient (NaCl)
build system to port emacs to NaCl.  NaCl is a way to build native code
binaries to run as apps or in tabs in the chromium browser.

This is a part of an ongoing port to NaCl.  See
https://code.google.com/p/naclports/source/browse/trunk/src/ports/emacs/nacl.patch?spec=svn1621&r=1621
---
 ChangeLog    | 4 ++++
 configure.ac | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 4f6523e..d478283 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-13 Pete Williamson <petewil@chromium.org> (tiny change)
+
+	* configure.ac: Add a new supported OS type, NaCl
+
 2015-03-02  Robert Pluim  <rpluim@gmail.com>  (tiny change)
 
 	* configure.ac: Error out if with-file-notification=w32 is
diff --git a/configure.ac b/configure.ac
index d65494a..7da1c06 100644
--- a/configure.ac
+++ b/configure.ac
@@ -718,6 +718,11 @@ case "${canonical}" in
     esac
   ;;
 
+  ## NativeClient for Chromium
+  *-nacl )
+    opsys=nacl
+  ;;
+
   * )
     unported=yes
   ;;
-- 
2.2.0.rc0.207.ga3a616c


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-13 21:57 [PATCH] - Introduce reference to a new Emacs build target - NaCl Pete Williamson
@ 2015-03-13 23:44 ` Michal Nazarewicz
  2015-03-13 23:46   ` Pete Williamson
  2015-03-14  0:28 ` Paul Eggert
  1 sibling, 1 reply; 12+ messages in thread
From: Michal Nazarewicz @ 2015-03-13 23:44 UTC (permalink / raw)
  To: Pete Williamson, emacs-devel

On Fri, Mar 13 2015, Pete Williamson <petewil@google.com> wrote:
> @@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \
>
> test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
> case "$opsys" in
> + nacl) CANNOT_DUMP=yes ;;
> your-opsys-here) CANNOT_DUMP=yes ;;
> esac
>
> @@ -9828,6 +9833,7 @@ system_malloc=no
> case "$opsys" in
> ## darwin ld insists on the use of malloc routines in the System framework.
> darwin|sol2-10) system_malloc=yes ;;
> + nacl) system_malloc=yes ;;
> esac
>
> if test "${system_malloc}" = "yes"; then
> @@ -15169,7 +15175,7 @@ esac
> emacs_broken_SIGIO=no
>
> case $opsys in
> - hpux* | irix6-5 | openbsd | sol2* | unixware )
> + hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
> emacs_broken_SIGIO=yes
> ;;
>
> @@ -15277,7 +15283,7 @@ case $opsys in
>
> ;;
>
> - gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> + nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> if test "x$ac_cv_func_grantpt" = xyes; then
>
> $as_echo "#define UNIX98_PTYS 1" >>confdefs.h
> @@ -15430,7 +15436,7 @@ if test $emacs_glibc = yes; then
> emacs_pending_output=unknown
>
> case $opsys in
> - gnu | gnu-linux | gnu-kfreebsd )
> + nacl | gnu | gnu-linux | gnu-kfreebsd )
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending
> output formalism" >&5
> $as_echo_n "checking for style of pending output formalism... " >&6; }
> cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> @@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=
> ORDINARY_LINK=
> case "$opsys" in
> ## gnu: GNU needs its own crt0.
> - aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY_LINK=yes
> ;;
> + nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
> ORDINARY_LINK=yes ;;

So your patch, the attached file, is missing the above changes in the
configure.ac file.  Is that intentional?  I imagine it would make sense
to bundle them all together into a single patch.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-13 23:44 ` Michal Nazarewicz
@ 2015-03-13 23:46   ` Pete Williamson
  0 siblings, 0 replies; 12+ messages in thread
From: Pete Williamson @ 2015-03-13 23:46 UTC (permalink / raw)
  To: Michal Nazarewicz; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 2550 bytes --]

Yes, that's intentional, I wanted to vet the approach first.  If others
feel the same, I'm happy to move all the changes into my patch.
On Mar 13, 2015 4:44 PM, "Michal Nazarewicz" <mina86@mina86.com> wrote:
>
> On Fri, Mar 13 2015, Pete Williamson <petewil@google.com> wrote:
> > @@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \
> >
> > test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
> > case "$opsys" in
> > + nacl) CANNOT_DUMP=yes ;;
> > your-opsys-here) CANNOT_DUMP=yes ;;
> > esac
> >
> > @@ -9828,6 +9833,7 @@ system_malloc=no
> > case "$opsys" in
> > ## darwin ld insists on the use of malloc routines in the System
framework.
> > darwin|sol2-10) system_malloc=yes ;;
> > + nacl) system_malloc=yes ;;
> > esac
> >
> > if test "${system_malloc}" = "yes"; then
> > @@ -15169,7 +15175,7 @@ esac
> > emacs_broken_SIGIO=no
> >
> > case $opsys in
> > - hpux* | irix6-5 | openbsd | sol2* | unixware )
> > + hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
> > emacs_broken_SIGIO=yes
> > ;;
> >
> > @@ -15277,7 +15283,7 @@ case $opsys in
> >
> > ;;
> >
> > - gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > + nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > if test "x$ac_cv_func_grantpt" = xyes; then
> >
> > $as_echo "#define UNIX98_PTYS 1" >>confdefs.h
> > @@ -15430,7 +15436,7 @@ if test $emacs_glibc = yes; then
> > emacs_pending_output=unknown
> >
> > case $opsys in
> > - gnu | gnu-linux | gnu-kfreebsd )
> > + nacl | gnu | gnu-linux | gnu-kfreebsd )
> > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending
> > output formalism" >&5
> > $as_echo_n "checking for style of pending output formalism... " >&6; }
> > cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> > @@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=
> > ORDINARY_LINK=
> > case "$opsys" in
> > ## gnu: GNU needs its own crt0.
> > - aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
ORDINARY_LINK=yes
> > ;;
> > + nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
> > ORDINARY_LINK=yes ;;
>
> So your patch, the attached file, is missing the above changes in the
> configure.ac file.  Is that intentional?  I imagine it would make sense
> to bundle them all together into a single patch.
>
> --
> Best regards,                                         _     _
> .o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
> ..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
> ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--

[-- Attachment #2: Type: text/html, Size: 3599 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-13 21:57 [PATCH] - Introduce reference to a new Emacs build target - NaCl Pete Williamson
  2015-03-13 23:44 ` Michal Nazarewicz
@ 2015-03-14  0:28 ` Paul Eggert
  2015-03-14  0:29   ` Pete Williamson
  1 sibling, 1 reply; 12+ messages in thread
From: Paul Eggert @ 2015-03-14  0:28 UTC (permalink / raw)
  To: Pete Williamson, emacs-devel; +Cc: Michal Nazarewicz

Pete Williamson wrote:
> --- a/configure
> +++ b/configure

'configure' is generated automatically from 'configure.ac' and other files, so 
patches to 'configure' are ineffective.  You need to patch configure.ac and the 
other files instead.

If you need to patch config.guess and/or config.sub, they come from a different 
project and those changes need to be sent upstream, as described in those files.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-14  0:28 ` Paul Eggert
@ 2015-03-14  0:29   ` Pete Williamson
  2015-03-18 16:04     ` Pete Williamson
  0 siblings, 1 reply; 12+ messages in thread
From: Pete Williamson @ 2015-03-14  0:29 UTC (permalink / raw)
  To: Paul Eggert; +Cc: Michal Nazarewicz, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

The actual patch is to configure.ac.  The diff is showing things that I
would move from my current "configure" file to "configure.ac"

On Fri, Mar 13, 2015 at 5:28 PM, Paul Eggert <eggert@cs.ucla.edu> wrote:

> Pete Williamson wrote:
>
>> --- a/configure
>> +++ b/configure
>>
>
> 'configure' is generated automatically from 'configure.ac' and other
> files, so patches to 'configure' are ineffective.  You need to patch
> configure.ac and the other files instead.
>
> If you need to patch config.guess and/or config.sub, they come from a
> different project and those changes need to be sent upstream, as described
> in those files.
>

[-- Attachment #2: Type: text/html, Size: 1268 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-14  0:29   ` Pete Williamson
@ 2015-03-18 16:04     ` Pete Williamson
  2015-03-28  0:30       ` Pete Williamson
  0 siblings, 1 reply; 12+ messages in thread
From: Pete Williamson @ 2015-03-18 16:04 UTC (permalink / raw)
  To: Paul Eggert; +Cc: Michal Nazarewicz, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Since there has been no other feedback on this topic, I'll take Michal's
suggestion (and clear up Paul's confusion), and make all the changes to the
config.ac file at once, stay tuned for an updated patch.

On Fri, Mar 13, 2015 at 5:29 PM, Pete Williamson <petewil@google.com> wrote:

> The actual patch is to configure.ac.  The diff is showing things that I
> would move from my current "configure" file to "configure.ac"
>
> On Fri, Mar 13, 2015 at 5:28 PM, Paul Eggert <eggert@cs.ucla.edu> wrote:
>
>> Pete Williamson wrote:
>>
>>> --- a/configure
>>> +++ b/configure
>>>
>>
>> 'configure' is generated automatically from 'configure.ac' and other
>> files, so patches to 'configure' are ineffective.  You need to patch
>> configure.ac and the other files instead.
>>
>> If you need to patch config.guess and/or config.sub, they come from a
>> different project and those changes need to be sent upstream, as described
>> in those files.
>>
>
>

[-- Attachment #2: Type: text/html, Size: 1969 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-18 16:04     ` Pete Williamson
@ 2015-03-28  0:30       ` Pete Williamson
  2015-03-29 21:50         ` Paul Eggert
  0 siblings, 1 reply; 12+ messages in thread
From: Pete Williamson @ 2015-03-28  0:30 UTC (permalink / raw)
  To: Paul Eggert; +Cc: Michal Nazarewicz, emacs-devel


[-- Attachment #1.1: Type: text/plain, Size: 1684 bytes --]

Here is a fresh patch, all comments welcome!  As suggested, I've put all
the changes we need into the configure.ac file instead of just the first
one.

Again, this patch is to add the NaCl operating system for chromium into the
emacs configure.ac file.

As I mentioned in previous patch requests, I'm adding support for a new
build target, the chromium browser's Native Client (NaCl) platform.  We
have a patch for emacs working today (for some definitions of working ^_^)
in NaCl ports, and we would like to port the changes back to the emacs code
base.

Our work in progress is visible in the "naclports" github project.

On Wed, Mar 18, 2015 at 9:04 AM, Pete Williamson <petewil@google.com> wrote:

> Since there has been no other feedback on this topic, I'll take Michal's
> suggestion (and clear up Paul's confusion), and make all the changes to the
> config.ac file at once, stay tuned for an updated patch.
>
> On Fri, Mar 13, 2015 at 5:29 PM, Pete Williamson <petewil@google.com>
> wrote:
>
>> The actual patch is to configure.ac.  The diff is showing things that I
>> would move from my current "configure" file to "configure.ac"
>>
>> On Fri, Mar 13, 2015 at 5:28 PM, Paul Eggert <eggert@cs.ucla.edu> wrote:
>>
>>> Pete Williamson wrote:
>>>
>>>> --- a/configure
>>>> +++ b/configure
>>>>
>>>
>>> 'configure' is generated automatically from 'configure.ac' and other
>>> files, so patches to 'configure' are ineffective.  You need to patch
>>> configure.ac and the other files instead.
>>>
>>> If you need to patch config.guess and/or config.sub, they come from a
>>> different project and those changes need to be sent upstream, as described
>>> in those files.
>>>
>>
>>
>

[-- Attachment #1.2: Type: text/html, Size: 3470 bytes --]

[-- Attachment #2: 0001-Add-NaCl-to-the-list-of-supported-OSs.patch --]
[-- Type: text/x-patch, Size: 2960 bytes --]

From 2f619eed946635074be15ddca9311c1e78ebd8c9 Mon Sep 17 00:00:00 2001
From: Pete Williamson <petewil@chromium.org>
Date: Fri, 27 Mar 2015 17:24:23 -0700
Subject: [PATCH] Add NaCl to the list of supported OSs

This is the first part of adding support for the NativeClient (NaCl)
build system to port emacs to NaCl.  NaCl is a way to build native code
binaries to run as apps or in tabs in the chromium browser.

This is a part of an ongoing port to NaCl.  See
https://code.google.com/p/naclports/source/browse/trunk/src/ports/emacs/nacl.patch?spec=svn1621&r=1621
---
 ChangeLog    |  5 +++++
 configure.ac | 14 ++++++++++----
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a489ab9..d839b68 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-03027 Pete Williamson <petewil@chromium.org>
+
+	* configure.ac: Add a new supported target, Chromium Native Client
+	(NaCl).
+
 2015-03-23  Andreas Schwab  <schwab@suse.de>
 
 	* configure.ac: Fix jpeg version check to work with gcc >= 5.
diff --git a/configure.ac b/configure.ac
index bed94fb..4676fdd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -690,6 +690,11 @@ case "${canonical}" in
     esac
   ;;
 
+  ## Chromium Native Client
+  *-nacl  )
+    opsys=nacl
+  ;;
+
   ## Intel 386 machines where we don't care about the manufacturer.
   i[3456]86-*-* )
     case "${canonical}" in
@@ -1263,6 +1268,7 @@ dnl The function dump-emacs will not be defined and temacs will do
 dnl (load "loadup") automatically unless told otherwise.
 test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
 case "$opsys" in
+  nacl) CANNOT_DUMP=yes ;;
   your-opsys-here) CANNOT_DUMP=yes ;;
 esac
 
@@ -2104,7 +2110,7 @@ hybrid_malloc=
 
 case "$opsys" in
   ## darwin ld insists on the use of malloc routines in the System framework.
-  darwin|mingw32|sol2-10) system_malloc=yes ;;
+  darwin|mingw32|sol2-10|nacl) system_malloc=yes ;;
   cygwin) hybrid_malloc=yes;;
 esac
 
@@ -4186,7 +4192,7 @@ emacs_broken_SIGIO=no
 case $opsys in
   dnl SIGIO exists, but the feature doesn't work in the way Emacs needs.
   dnl See eg <http://article.gmane.org/gmane.os.openbsd.ports/46831>.
-  hpux* | irix6-5 | openbsd | sol2* | unixware )
+  hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
     emacs_broken_SIGIO=yes
     ;;
 
@@ -4348,7 +4354,7 @@ case $opsys in
     AC_DEFINE(FIRST_PTY_LETTER, ['p'])
     ;;
 
-  gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd )
+  gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd | nacl )
     dnl if HAVE_GRANTPT
     if test "x$ac_cv_func_grantpt" = xyes; then
       AC_DEFINE(UNIX98_PTYS, 1, [Define if the system has Unix98 PTYs.])
@@ -4647,7 +4653,7 @@ esac
 
 AC_CACHE_CHECK([for usable FIONREAD], [emacs_cv_usable_FIONREAD],
   [case $opsys in
-     aix4-2)
+     aix4-2 | nacl)
        dnl BUILD 9008 - FIONREAD problem still exists in X-Windows.
        emacs_cv_usable_FIONREAD=no
        ;;
-- 
2.2.0.rc0.207.ga3a616c


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-28  0:30       ` Pete Williamson
@ 2015-03-29 21:50         ` Paul Eggert
  2015-03-30 10:12           ` Richard Stallman
  0 siblings, 1 reply; 12+ messages in thread
From: Paul Eggert @ 2015-03-29 21:50 UTC (permalink / raw)
  To: Pete Williamson; +Cc: Michal Nazarewicz, emacs-devel

In <https://lists.gnu.org/archive/html/emacs-devel/2015-03/msg00889.html> Pete 
Williamson wrote:

> this patch is to add the NaCl operating system for chromium into the
> emacs configure.ac file.

Thanks, I did a bit more reading about NaCl and in 
<https://developer.chrome.com/native-client> I ran across the statement "NaCl 
modules must be run from the Chrome Web Store (CWS)".

At first glance this restriction appears to conflict with the GNU General Public 
License that GNU Emacs is distributed under.  If so, I'm not seeing how it'd be 
useful to apply that patch to the GNU Emacs source, as the patch would cause the 
resulting NaCl executable to not be redistributable under the license terms of 
GNU Emacs.  If I am misunderstanding the situation, could you please explain 
things?  Thanks.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-29 21:50         ` Paul Eggert
@ 2015-03-30 10:12           ` Richard Stallman
  2015-03-30 21:41             ` Pete Williamson
  0 siblings, 1 reply; 12+ messages in thread
From: Richard Stallman @ 2015-03-30 10:12 UTC (permalink / raw)
  To: Paul Eggert; +Cc: mina86, petewil, emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Thanks, I did a bit more reading about NaCl and in 
  > <https://developer.chrome.com/native-client> I ran across the statement "NaCl 
  > modules must be run from the Chrome Web Store (CWS)".


I will take a look.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! See stallman.org/skype.html.




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-30 10:12           ` Richard Stallman
@ 2015-03-30 21:41             ` Pete Williamson
  2015-03-31 14:06               ` Richard Stallman
  0 siblings, 1 reply; 12+ messages in thread
From: Pete Williamson @ 2015-03-30 21:41 UTC (permalink / raw)
  To: rms; +Cc: Paul Eggert, Michal Nazarewicz, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]

Sorry, that page is misleading when taken from a licensing point of view,
I've notified the NaCl SDK team and they'll look into revising the wording.

The statement "NaCl modules must be run from the Chrome Web Store (CWS)" is
a statement about what the browser permits without user action *by default*,
not a licensing statement.
It was meant to contrast with the statement above it regarding PNaCl
(portable native client), which the browser will by default load from any
page.
Users of Chrome or Chromium can opt into running NaCl modules on web pages
outside the Web Store from about://flags. Additionally Chrome Apps can be
side-loaded from the chrome://extensions page or at the command line.

The NaCl port of Emacs will run in both chrome and chromium.  While we do
plan to make a copy of Emacs available (for $0, and with a link to source)
in the Chrome Web Store, the web store is not a requirement, and can be
bypassed completely in several ways. The first is to "sideload" the app
from chrome://extensions (this is for example how I test local builds).
Chrome and chromium can also be run with the "--load-and-launch-app"
command line flag, which allows the user to load any chrome app from any
directory.  Additionally, we hope to eventually complete a PNaCl port of
Emacs.  In the default configuration of Chrome/Chromium, this will allow a
web page with part of the page running full emacs, downloaded on demand.

NaCl Emacs can be compiled today from the open source patches and scripts
in the https://chromium.googlesource.com/external/naclports.gitrepository,
and is being redistributed freely already.

Does this address you concerns?

On Mon, Mar 30, 2015 at 3:12 AM, Richard Stallman <rms@gnu.org> wrote:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > Thanks, I did a bit more reading about NaCl and in
>   > <https://developer.chrome.com/native-client> I ran across the
> statement "NaCl
>   > modules must be run from the Chrome Web Store (CWS)".
>
>
> I will take a look.
>
> --
> Dr Richard Stallman
> President, Free Software Foundation
> 51 Franklin St
> Boston MA 02110
> USA
> www.fsf.org  www.gnu.org
> Skype: No way! See stallman.org/skype.html.
>
>

[-- Attachment #2: Type: text/html, Size: 4055 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-30 21:41             ` Pete Williamson
@ 2015-03-31 14:06               ` Richard Stallman
  2015-03-31 18:29                 ` Paul Eggert
  0 siblings, 1 reply; 12+ messages in thread
From: Richard Stallman @ 2015-03-31 14:06 UTC (permalink / raw)
  To: Pete Williamson; +Cc: eggert, mina86, emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > The statement "NaCl modules must be run from the Chrome Web Store (CWS)" is
  > a statement about what the browser permits without user action *by default*,
  > not a licensing statement.

  > Users of Chrome or Chromium can opt into running NaCl modules on web pages
  > outside the Web Store from about://flags. Additionally Chrome Apps can be
  > side-loaded from the chrome://extensions page or at the command line.

Based on your explanation, there's no real issue here.
Thanks.

  > NaCl Emacs can be compiled today from the open source patches and scripts

Would you please help our cause by not calling them "open source"?

See http://gnu.org/philosophy/open-source-misses-the-point.html
for more explanation of the difference between free software and open
source.  See also http://thebaffler.com/past/the_meme_hustler for
Evgeny Morozov's article on the same point.


-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! See stallman.org/skype.html.




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl
  2015-03-31 14:06               ` Richard Stallman
@ 2015-03-31 18:29                 ` Paul Eggert
  0 siblings, 0 replies; 12+ messages in thread
From: Paul Eggert @ 2015-03-31 18:29 UTC (permalink / raw)
  To: rms, Pete Williamson; +Cc: mina86, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On 03/31/2015 07:06 AM, Richard Stallman wrote:
> there's no real issue here.
Thanks for looking into it.  I installed the attached patch, which is 
essentially Pete's patch but with minor sorting and suchlike changes.  I 
marked it as "tiny change" as it's small enough that we needn't worry 
about copyright papers.

[-- Attachment #2: 0001-Pete-Williamson-petewil-chromium.org-tiny-change.patch --]
[-- Type: text/x-patch, Size: 2706 bytes --]

From d5ee541f9a8aa36877e9034829fb3171ad0f8c99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
Date: Tue, 31 Mar 2015 11:26:48 -0700
Subject: [PATCH] Pete Williamson  <petewil@chromium.org>  (tiny change)

Add NaCl target
* configure.ac: Add a target for Chromium Native Client (NaCl).
---
 ChangeLog    |  5 +++++
 configure.ac | 15 ++++++++++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f45e32f..6df5a5a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-27  Pete Williamson  <petewil@chromium.org>  (tiny change)
+
+	Add NaCl target
+	* configure.ac: Add a target for Chromium Native Client (NaCl).
+
 2015-03-29  Eli Zaretskii  <eliz@gnu.org>
 
 	* build-aux/dir_top (File): Fix the description of selecting a
diff --git a/configure.ac b/configure.ac
index bed94fb..44709d4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -612,6 +612,11 @@ case "${canonical}" in
 ##    fi
   ;;
 
+  ## Chromium Native Client
+  *-nacl )
+    opsys=nacl
+  ;;
+
   ## Cygwin ports
   *-*-cygwin )
     opsys=cygwin
@@ -1263,7 +1268,7 @@ dnl The function dump-emacs will not be defined and temacs will do
 dnl (load "loadup") automatically unless told otherwise.
 test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
 case "$opsys" in
-  your-opsys-here) CANNOT_DUMP=yes ;;
+  nacl) CANNOT_DUMP=yes ;;
 esac
 
 if test "$CANNOT_DUMP" = "yes"; then
@@ -2104,7 +2109,7 @@ hybrid_malloc=
 
 case "$opsys" in
   ## darwin ld insists on the use of malloc routines in the System framework.
-  darwin|mingw32|sol2-10) system_malloc=yes ;;
+  darwin | mingw32 | nacl | sol2-10) system_malloc=yes ;;
   cygwin) hybrid_malloc=yes;;
 esac
 
@@ -4186,7 +4191,7 @@ emacs_broken_SIGIO=no
 case $opsys in
   dnl SIGIO exists, but the feature doesn't work in the way Emacs needs.
   dnl See eg <http://article.gmane.org/gmane.os.openbsd.ports/46831>.
-  hpux* | irix6-5 | openbsd | sol2* | unixware )
+  hpux* | irix6-5 | nacl | openbsd | sol2* | unixware )
     emacs_broken_SIGIO=yes
     ;;
 
@@ -4348,7 +4353,7 @@ case $opsys in
     AC_DEFINE(FIRST_PTY_LETTER, ['p'])
     ;;
 
-  gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd )
+  gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd | nacl )
     dnl if HAVE_GRANTPT
     if test "x$ac_cv_func_grantpt" = xyes; then
       AC_DEFINE(UNIX98_PTYS, 1, [Define if the system has Unix98 PTYs.])
@@ -4647,7 +4652,7 @@ esac
 
 AC_CACHE_CHECK([for usable FIONREAD], [emacs_cv_usable_FIONREAD],
   [case $opsys in
-     aix4-2)
+     aix4-2 | nacl)
        dnl BUILD 9008 - FIONREAD problem still exists in X-Windows.
        emacs_cv_usable_FIONREAD=no
        ;;
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-03-31 18:29 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 21:57 [PATCH] - Introduce reference to a new Emacs build target - NaCl Pete Williamson
2015-03-13 23:44 ` Michal Nazarewicz
2015-03-13 23:46   ` Pete Williamson
2015-03-14  0:28 ` Paul Eggert
2015-03-14  0:29   ` Pete Williamson
2015-03-18 16:04     ` Pete Williamson
2015-03-28  0:30       ` Pete Williamson
2015-03-29 21:50         ` Paul Eggert
2015-03-30 10:12           ` Richard Stallman
2015-03-30 21:41             ` Pete Williamson
2015-03-31 14:06               ` Richard Stallman
2015-03-31 18:29                 ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).