unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Default change in elisp indentation [Probably 4713dd4?]
@ 2017-04-24 20:28 Kaushal Modi
  2017-04-24 20:39 ` Kaushal Modi
  2017-04-24 20:44 ` Noam Postavsky
  0 siblings, 2 replies; 4+ messages in thread
From: Kaushal Modi @ 2017-04-24 20:28 UTC (permalink / raw)
  To: Emacs developers, Noam Postavsky


[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]

Hi,

I suddenly noticed that the default indentation has changed.

This indents correctly:

(defun foo()
  "foo"
  (interactive)
  (message "foo"))

But if the doc-string is multi-line, it now indents like this:

(defun foo()
  "foo
bar"
       (interactive)
       (message "foo"))

I searched for "indent" in recent commit history, and I believe it is this
commit:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4713dd425beac5cb459704e67dcb8f6faf714375

[image: pasted1][image: pasted2][image: pasted3][image: pasted4][image:
pasted5]


-- 

Kaushal Modi

[-- Attachment #1.2: Type: text/html, Size: 1535 bytes --]

[-- Attachment #2: pasted3 --]
[-- Type: image/png, Size: 18861 bytes --]

[-- Attachment #3: pasted1 --]
[-- Type: image/png, Size: 18861 bytes --]

[-- Attachment #4: pasted2 --]
[-- Type: image/png, Size: 18861 bytes --]

[-- Attachment #5: pasted4 --]
[-- Type: image/png, Size: 18861 bytes --]

[-- Attachment #6: pasted5 --]
[-- Type: image/png, Size: 18861 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Default change in elisp indentation [Probably 4713dd4?]
  2017-04-24 20:28 Default change in elisp indentation [Probably 4713dd4?] Kaushal Modi
@ 2017-04-24 20:39 ` Kaushal Modi
  2017-04-24 20:44 ` Noam Postavsky
  1 sibling, 0 replies; 4+ messages in thread
From: Kaushal Modi @ 2017-04-24 20:39 UTC (permalink / raw)
  To: Emacs developers, Noam Postavsky

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

On Mon, Apr 24, 2017 at 4:28 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> Hi,
>
> I suddenly noticed that the default indentation has changed.
>

Sorry, somehow that image got pasted 5 times..
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 675 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Default change in elisp indentation [Probably 4713dd4?]
  2017-04-24 20:28 Default change in elisp indentation [Probably 4713dd4?] Kaushal Modi
  2017-04-24 20:39 ` Kaushal Modi
@ 2017-04-24 20:44 ` Noam Postavsky
  2017-04-24 20:56   ` Kaushal Modi
  1 sibling, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2017-04-24 20:44 UTC (permalink / raw)
  To: Kaushal Modi; +Cc: Emacs developers

On Mon, Apr 24, 2017 at 4:28 PM, Kaushal Modi <kaushal.modi@gmail.com> wrote:
> Hi,
>
> I suddenly noticed that the default indentation has changed.
>
> This indents correctly:
>
> (defun foo()
>   "foo"
>   (interactive)
>   (message "foo"))
>
> But if the doc-string is multi-line, it now indents like this:
>
> (defun foo()
>   "foo
> bar"
>        (interactive)
>        (message "foo"))

Yup, see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26619 for a patch.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Default change in elisp indentation [Probably 4713dd4?]
  2017-04-24 20:44 ` Noam Postavsky
@ 2017-04-24 20:56   ` Kaushal Modi
  0 siblings, 0 replies; 4+ messages in thread
From: Kaushal Modi @ 2017-04-24 20:56 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Mon, Apr 24, 2017 at 4:44 PM Noam Postavsky <npostavs@gmail.com> wrote:

>
> Yup, see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26619 for a patch.
>

Thanks. While this fixes the multi-line string indentation, one other
indentation scenario is still broken.. I will continue on that debbugs
thread.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 775 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-24 20:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-24 20:28 Default change in elisp indentation [Probably 4713dd4?] Kaushal Modi
2017-04-24 20:39 ` Kaushal Modi
2017-04-24 20:44 ` Noam Postavsky
2017-04-24 20:56   ` Kaushal Modi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).