From: Kaushal Modi <kaushal.modi@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Relics of removed dir-locals-file-2 feature in pretest
Date: Wed, 22 Nov 2017 16:28:18 +0000 [thread overview]
Message-ID: <CAFyQvY3qFvYjWSxSAsjV_TtXGLXaUsWvCnNKug-_9WCOhwJn7Q@mail.gmail.com> (raw)
In-Reply-To: <83lgiyb801.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, Nov 22, 2017 at 11:20 AM Eli Zaretskii <eliz@gnu.org> wrote:
> So I really don't understand what is the issue that needs to be fixed.
>
OK, at the risk of sounding very stupid.. this feature was removed and then
added again in this commit:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=da976cff352bdea6adc2667582a56eb4061bb5f6
Right?
The defconst dir-locals-file-2 is added in that commit, but is not used
anywhere.
Looking at the dir-locals--all-files code in that commit, from what I
understand, the let-bound file-2 derivation is hard-coded, and has nothing
to do with dir-locals-file-2:
(file-2 (when (string-match "\\.el\\'" file-1)
(replace-match "-2.el" t nil file-1)))
Is that correct? So should the dir-locals-file-2 defconst and all its
mentions be removed from doc? Or should that var instead be used in
dir-locals--all-files and wherever else applicable?
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1628 bytes --]
next prev parent reply other threads:[~2017-11-22 16:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:58 Relics of removed dir-locals-file-2 feature in pretest Kaushal Modi
2017-11-21 19:56 ` Kaushal Modi
2017-11-21 20:33 ` Eli Zaretskii
2017-11-21 21:11 ` Kaushal Modi
2017-11-22 15:19 ` Eli Zaretskii
2017-11-22 15:58 ` Kaushal Modi
2017-11-22 16:20 ` Eli Zaretskii
2017-11-22 16:28 ` Kaushal Modi [this message]
2017-11-23 15:53 ` Eli Zaretskii
2017-11-23 17:34 ` Kaushal Modi
2017-11-23 20:08 ` Eli Zaretskii
2017-11-27 14:57 ` Kaushal Modi
2017-11-27 16:14 ` Eli Zaretskii
2017-11-27 17:04 ` Kaushal Modi
2017-11-27 17:27 ` Eli Zaretskii
2017-11-27 17:50 ` Kaushal Modi
2017-11-28 17:19 ` Eli Zaretskii
2017-11-28 17:34 ` Kaushal Modi
2017-11-28 17:51 ` Eli Zaretskii
2017-11-28 17:59 ` Kaushal Modi
2017-11-28 20:02 ` Davis Herring
2017-11-28 20:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY3qFvYjWSxSAsjV_TtXGLXaUsWvCnNKug-_9WCOhwJn7Q@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).