From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: Relics of removed dir-locals-file-2 feature in pretest Date: Wed, 22 Nov 2017 16:28:18 +0000 Message-ID: References: <833757cqy7.fsf@gnu.org> <83tvxmbat5.fsf@gnu.org> <83lgiyb801.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c1284944e5058055e94cfb0" X-Trace: blaine.gmane.org 1511368129 20024 195.159.176.226 (22 Nov 2017 16:28:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 16:28:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 22 17:28:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHXt3-0004E4-4g for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 17:28:33 +0100 Original-Received: from localhost ([::1]:40273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXtA-0004fE-Fq for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 11:28:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXt3-0004f6-B3 for emacs-devel@gnu.org; Wed, 22 Nov 2017 11:28:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHXt2-0007ec-D8 for emacs-devel@gnu.org; Wed, 22 Nov 2017 11:28:33 -0500 Original-Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]:38080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHXt0-0007dx-Px; Wed, 22 Nov 2017 11:28:30 -0500 Original-Received: by mail-yw0-x234.google.com with SMTP id v195so3632804ywg.5; Wed, 22 Nov 2017 08:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wno14E/ACD0h2/KC7aJMLE1HKQYQI3ht1rPjLo6fOl0=; b=WcIs6F6ADG6/9m4+Fds71lfJRUh5lcFwpfU1HkeVcpvsmm7JvEco1gEStXb63o+K2E IeTNZLYXCCeOHP5xmdIOxrhsfes8HzUCAFlTUtbYHuZqNr3gfCDlF47OfzPBeds5wrCe xNrVRjzfMpUFghkG4xAd4/eJ3RcE1YnSu1NRce+0e8sClC/cofdbPfN62i7CFJjFi6qP 6BGajmJ/zi9zh0Ybid5aj4owz6FIg1mb4n35fdykiDvYA+ZCrHFu+IHgTKwKqTVs+MkX FYPZ+PUHiVt3Vk7UaZtsjXR1WJOZyftYOg+5UPpBElCIuB884l8a+bLHTkvCAC6XykWH pTWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wno14E/ACD0h2/KC7aJMLE1HKQYQI3ht1rPjLo6fOl0=; b=CAAIjmYfX31Ew/9HvCW3IaJJmn+WVZDrKsqeenAHd18umpklKkT9f2DcP+hdzXnSUT 2LAOfaL7sc2EqMH3+qH/Blr1I71MTp9kTIDuM/StkhK3owopz8oWSZirhfOGIJqDiizq X9jawGUAY8vMwkYiri6mjAyzPd7QN1MefVpU4jn1dEAZd68SC78La7mEzXFRN61acJwa fcs72aRi+JFOhuXas4GjHdHrWxPBpXl+Hv/0PyN9LXy3H97/ctcUViAHI3LEMfcyS5+I U3+BXnH0Y4jhdqU66veCH/kZk8Y4tmF+n3g8ZjO5HgRQu7MArXpWAgbUWmI4aWcBxJUT RiEA== X-Gm-Message-State: AJaThX5ry+sOiqFuoU/6a3J0kd5EX5YLgOkDLvGEHTEsWxyYgG//2ATP 6ox2X2oUttcZEb8zqjtfxKiCZmYufm2DjTMayV0= X-Google-Smtp-Source: AGs4zMapYMKX1eogd66VV/IxLE2WhYoJ5wZTGGPQXfCcf99lBzOaHdtrQdNzBhZn2MPjFcqGNjmDmWwy4JC/sogJNoo= X-Received: by 10.129.165.18 with SMTP id c18mr13789593ywh.484.1511368109737; Wed, 22 Nov 2017 08:28:29 -0800 (PST) In-Reply-To: <83lgiyb801.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220361 Archived-At: --94eb2c1284944e5058055e94cfb0 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 22, 2017 at 11:20 AM Eli Zaretskii wrote: > So I really don't understand what is the issue that needs to be fixed. > OK, at the risk of sounding very stupid.. this feature was removed and then added again in this commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=da976cff352bdea6adc2667582a56eb4061bb5f6 Right? The defconst dir-locals-file-2 is added in that commit, but is not used anywhere. Looking at the dir-locals--all-files code in that commit, from what I understand, the let-bound file-2 derivation is hard-coded, and has nothing to do with dir-locals-file-2: (file-2 (when (string-match "\\.el\\'" file-1) (replace-match "-2.el" t nil file-1))) Is that correct? So should the dir-locals-file-2 defconst and all its mentions be removed from doc? Or should that var instead be used in dir-locals--all-files and wherever else applicable? -- Kaushal Modi --94eb2c1284944e5058055e94cfb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 22= , 2017 at 11:20 AM Eli Zaretskii <eliz@g= nu.org> wrote:
So I really d= on't understand what is the issue that needs to be fixed.

OK, at the risk of sounding very stupid.. this featu= re was removed and then added again in this commit: http://git.savannah.gnu.org/cgit/emacs.git/comm= it/?h=3Demacs-26&id=3Dda976cff352bdea6adc2667582a56eb4061bb5f6

Right?

The defconst dir-local= s-file-2 is added in that commit, but is not used anywhere.

<= /div>
Looking at the dir-locals--all-files code in that commit, from wh= at I understand, the let-bound file-2 derivation is hard-coded, and has not= hing to do with dir-locals-file-2:

=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-2 (when (string-match &= quot;\\.el\\'" file-1)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (replace-match "-2.el" t nil file-1)))

Is that correct? So should the dir-locals-file-2 defconst and all its= mentions be removed from doc? Or should that var instead be used in dir-lo= cals--all-files and wherever else applicable?
--

Kaushal Modi

--94eb2c1284944e5058055e94cfb0--