Issue with font rendering caused by one of the commits in last 48 hrs #master

Issue with font rendering caused by one of the commits in last 48 hrs #master

[Kaushal Modi]

[-- Attachment #1.1: Type: text/plain, Size: 1278 bytes --]

Hello all,

I keep my emacs build updated from the master branch pretty regularly.

My last build was using this build:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8c0fcaf66733f0538a3f024f383cb34a3c93d73c
and
that was good.

A while back, I built using
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5e42cefd7f2eb47d2c8660a7a317e8b08d36a82
and
that has font issues.. whether launching emacs directly or emacsclient.

So one of these 4 commits has caused the issue:

e5e42cefd7 * origin/master origin/HEAD master diff-hunk-kill independent of
point inside headers
1508b538fd * ; Revert "Improve diff-mode navigation/manipulation"
82a5e4dc88 * Fix free var FOO-mode-{syntax,abbrev}-table warnings
9c4e3097b5 * Check that variable lists are actually lists


Following images show the issue:
Notice that I am using the exact same emacs config with the exact same
fonts (PragmataPro) set in ~/.Xdefaults. Also I did not see any errors in
the *Messages* buffer at startup.

Good build (8c0fcaf). This is what the fonts looked like:
[image: pasted1]

Bad build (e5e42ce): This is what it looks in the latest build. Notice that
fonts look weird and the vertical pipe char is all misaligned.
[image: pasted2]

Is anyone seeing similar issue?

Thanks.
-- 

Kaushal Modi

[-- Attachment #1.2: Type: text/html, Size: 2116 bytes --]

[-- Attachment #2: pasted1 --]
[-- Type: image/png, Size: 414257 bytes --]

[-- Attachment #3: pasted2 --]
[-- Type: image/png, Size: 291600 bytes --]

Re: Issue with font rendering caused by one of the commits in last 48 hrs #master

[Tino Calancha]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]



On Sat, 21 Jan 2017, Kaushal Modi wrote:

> Hello all,
> I keep my emacs build updated from the master branch pretty regularly.
> 
> My last build was using this
> build: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8c0fcaf66733f0538a3f024f383cb34a3c93d73c and that was good.
> 
> A while back, I built using http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5e42cefd7f2eb47d2c8660a7a317e8b08d36a82 and
> that has font issues.. whether launching emacs directly or emacsclient. 
> 
> So one of these 4 commits has caused the issue:
> 
> e5e42cefd7 * origin/master origin/HEAD master diff-hunk-kill independent of point inside headers
> 1508b538fd * ; Revert "Improve diff-mode navigation/manipulation"
> 82a5e4dc88 * Fix free var FOO-mode-{syntax,abbrev}-table warnings
> 9c4e3097b5 * Check that variable lists are actually lists
I don't see this issue in my box.
Is it feasible for you to perform a git bisect?

Re: Issue with font rendering caused by one of the commits in last 48 hrs #master

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Sat, 21 Jan 2017 05:45:53 +0000
> 
> My last build was using this build:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8c0fcaf66733f0538a3f024f383cb34a3c93d73c and
> that was good.
> 
> A while back, I built using
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5e42cefd7f2eb47d2c8660a7a317e8b08d36a82 and
> that has font issues.. whether launching emacs directly or emacsclient. 
> 
> So one of these 4 commits has caused the issue:
> 
> e5e42cefd7 * origin/master origin/HEAD master diff-hunk-kill independent of point inside headers
> 1508b538fd * ; Revert "Improve diff-mode navigation/manipulation"
> 82a5e4dc88 * Fix free var FOO-mode-{syntax,abbrev}-table warnings
> 9c4e3097b5 * Check that variable lists are actually lists
> 
> Following images show the issue:
> Notice that I am using the exact same emacs config with the exact same fonts (PragmataPro) set in
> ~/.Xdefaults. Also I did not see any errors in the *Messages* buffer at startup.

Please post more details about "the issue".  The only thing I can
glean from the images is that the "good" version uses a fixed-pitch
face, while the "bad" one uses a variable-pitch face.  Your help is
needed in identifying the exact problem you are seeing.  E.g., is the
same font used in both cases?  What do you see in the Custom buffer if
you try to customize the face used by this display?  Etc. etc. -- any
additional details related to what you see will get us closer to
unlocking the mystery.

(I also wonder why you post here and not to the bug tracker.)

Thanks.

Re: Issue with font rendering caused by one of the commits in last 48 hrs #master

[Noam Postavsky]

On Sat, Jan 21, 2017 at 12:45 AM, Kaushal Modi <kaushal.modi@gmail.com> wrote:
> Hello all,
>
> I keep my emacs build updated from the master branch pretty regularly.
>
> My last build was using this build:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8c0fcaf66733f0538a3f024f383cb34a3c93d73c
> and that was good.
>
> A while back, I built using
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5e42cefd7f2eb47d2c8660a7a317e8b08d36a82
> and that has font issues.. whether launching emacs directly or emacsclient.
>
> So one of these 4 commits has caused the issue:
>
> e5e42cefd7 * origin/master origin/HEAD master diff-hunk-kill independent of
> point inside headers
> 1508b538fd * ; Revert "Improve diff-mode navigation/manipulation"
> 82a5e4dc88 * Fix free var FOO-mode-{syntax,abbrev}-table warnings
> 9c4e3097b5 * Check that variable lists are actually lists

I can't see a plausible way any these could affect the font, are you
sure it wasn't the commit I pushed last night [1: 6a788d2]?

1: 2017-01-20 23:36:26 -0500 6a788d2fc18c23dcfc5d0352649b2f690e9cbff7
  Don't wait for frame to become visible

Re: Issue with font rendering caused by one of the commits in last 48 hrs #master

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 2890 bytes --]

Hello everyone,

I apologize, but I cannot recreate the issue I saw last night. It's very
strange given that the 'bad' build and 'good' build were installed with
different --prefix flags. So they are 'make install'ed in completely
separate directories.

Though my building directory is the same.

Here are the sequence of events:

1. I update my build to
    e5e42ce diff-hunk-kill independent of point inside headers
2. Start a fresh emacsclient session, and see that issue.
3. I keep that session open, checkout the branch that last worked fine for
me:
    8c0fcaf Avoid inefficient regex in diff-refine-hunk
4. I take a screenshot of the bad build and kill that session.
5. Start another fresh emacsclient session using the build of the 'good'
branch.
6. And everything looks good again.

Sorry guys, as the issue magically went away, I fear it will arrive again.
Will open a bug report next time with more info as possible.

======
On Sat, Jan 21, 2017 at 9:02 AM Noam Postavsky <
npostavs@users.sourceforge.net> wrote:

I can't see a plausible way any these could affect the font, are you
sure it wasn't the commit I pushed last night [1: 6a788d2]?

1: 2017-01-20 23:36:26 -0500 6a788d2fc18c23dcfc5d0352649b2f690e9cbff7
  Don't wait for frame to become visible


Thanks for the reply, yes I confirmed that was not the case. This was my
emacs build info:

===
Emacs version: GNU Emacs 26.0.50.20 (x86_64-unknown-linux-gnu, GTK+ Version
2.24.23)
 of 2017-01-20, built using commit e5e42cefd7f2eb47d2c8660a7a317e8b08d36a82.

./configure options:
  --with-modules --prefix=/home/kmodi/usr_local/apps/6/emacs/master
'--program-transform-name=s/^ctags$/ctags_emacs/' 'CPPFLAGS=-fgnu89-inline
-I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include'
'CFLAGS=-ggdb3 -O0' 'CXXFLAGS=-ggdb3 -O0'
'LDFLAGS=-L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64
-ggdb3'

Features:
  XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES
===

>> Tino Calancha
> I don't see this issue in my box.
> Is it feasible for you to perform a git bisect?

Sorry, that's what I was just trying to do, but cannot recreate the issue.
:(

>> Eli Zaretskii

> The only thing I can glean from the images is that the "good" version
uses a fixed-pitch
> face, while the "bad" one uses a variable-pitch face.

It's the exact same font and exact same emacs config.

> E.g., is the same font used in both cases?

Yes.

> What do you see in the Custom buffer if you try to customize the face
used by this display?

Ah! Sorry, should have done that. But cannot recreate the issue. Sorry.

> (I also wonder why you post here and not to the bug tracker.)

Will do that next time. I did not see an "error message" or debug info to
report other than the screenshot.

-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 8322 bytes --]