[bug-report] e65c307 breaks font-height

[bug-report] e65c307 breaks font-height

[Rostislav Svoboda]

It looks like the semicolon in ":user-spec" causes unexpected
font-height increase.
I'm not sure if screenshots help:
http://picpaste.com/emacs-bad-e65c307.png
http://picpaste.com/emacs-good-c8b868b.png

Is there a problem in the e65c307 or in my emacs configuration?

thx Bost


~/dev/emacs-25 $ git show
commit e65c3079c65595d95749348366af9811fafff062
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Sun Mar 27 15:02:37 2016 -0700

    * src/font.c (QCuser_spec): Add missing colon to :user-spec.

diff --git a/src/font.c b/src/font.c
index 5ab3b3e..2519599 100644
--- a/src/font.c
+++ b/src/font.c
@@ -5317,7 +5317,7 @@ syms_of_font (void)
   DEFSYM (Qja, "ja");
   DEFSYM (Qko, "ko");

-  DEFSYM (QCuser_spec, "user-spec");
+  DEFSYM (QCuser_spec, ":user-spec");

   staticpro (&scratch_font_spec);
   scratch_font_spec = Ffont_spec (0, NULL);

Re: [bug-report] e65c307 breaks font-height

[Paul Eggert]

On 03/29/2016 05:48 AM, Rostislav Svoboda wrote:
> It looks like the semicolon in ":user-spec" causes unexpected
> font-height increase.
> I'm not sure if screenshots help:
> http://picpaste.com/emacs-bad-e65c307.png
> http://picpaste.com/emacs-good-c8b868b.png
>
> Is there a problem in the e65c307 or in my emacs configuration?

It's pretty clear that the intent here (and elsewhere in Emacs) is that 
the C identifier 'QCuser_spec' stands for the Emacs symbol ':user-spec', 
not for the Emacs symbol 'user-spec'.

It is possible that the change exposed some other bug in Emacs (perhaps 
related to font-setting-change-default-font? perhaps you could put a 
breakpoint on that function and see what it's doing). Or, it's 
conceivable that your Emacs configuration uses 'user-spec' where it 
should use ':user-spec'.

> thx Bost
>
>
> ~/dev/emacs-25 $ git show
> commit e65c3079c65595d95749348366af9811fafff062
> Author: Paul Eggert<eggert@cs.ucla.edu>
> Date:   Sun Mar 27 15:02:37 2016 -0700
>
>      * src/font.c (QCuser_spec): Add missing colon to :user-spec.
>
> diff --git a/src/font.c b/src/font.c
> index 5ab3b3e..2519599 100644
> --- a/src/font.c
> +++ b/src/font.c
> @@ -5317,7 +5317,7 @@ syms_of_font (void)
>     DEFSYM (Qja, "ja");
>     DEFSYM (Qko, "ko");
>
> -  DEFSYM (QCuser_spec, "user-spec");
> +  DEFSYM (QCuser_spec, ":user-spec");

Re: [bug-report] e65c307 breaks font-height

[Rostislav Svoboda]

>> Is there a problem in the e65c307 or in my emacs configuration?

Just to be sure - I did make clean && make bootstrap

After that I put a log-message right on the top of
font-setting-change-default-font in lisp/dynamic-setting.el and
byte-compiled the file.  I launch emacs in default configuration
using:
 ./src/emacs -q --eval "(set-face-attribute 'default nil :height 80)" &

A *scratch* with font-height 80 appears but immediatelly right after
that the font-height gets increased. Moreover my log-message does not
appear in the *Messages*.

So I think the e65c307 exposes some other bug indeed, but it is
specific to just one particular computer. On my other computer
everything is fine.

Do you have any other idea where should I take a look or put a
breakpoint?

thx Bost

Re: [bug-report] e65c307 breaks font-height

[Paul Eggert]

Rostislav Svoboda wrote:
> Do you have any other idea where should I take a look or put a
> breakpoint?

I'm afraid nothing comes to mind.