Re: master a34650a: Fix sloppy base64 acceptance of some multibyte characters

Re: master a34650a: Fix sloppy base64 acceptance of some multibyte characters

[Stefan Kangas]

mattiase@acm.org (Mattias Engdegård) writes:

> branch: master
> commit a34650acff3740980ef23d900d35004bcfe2ef04
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     Fix sloppy base64 acceptance of some multibyte characters

This change (or some other recent change) resulted in these test
failures:

Running 2 tests (2021-12-20 22:36:49+0100, selector ‘(not (or (tag
:expensive-test) (tag :unstable)))’)
Test sasl-scram-sha-1-test backtrace:
  signal(error ("Multibyte character in data for base64 encoding"))
  apply(signal (error ("Multibyte character in data for base64 encodin
  #f(compiled-function () #<bytecode 0x25099451700d3a5>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name sasl-scram-sha-1-test :documentation
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/sasl-scram-rfc-t
  command-line()
  normal-top-level()
Test sasl-scram-sha-1-test condition:
    (error "Multibyte character in data for base64 encoding")
   FAILED  1/2  sasl-scram-sha-1-test (0.143742 sec)
Test sasl-scram-sha-256-test backtrace:
  signal(error ("Multibyte character in data for base64 encoding"))
  apply(signal (error ("Multibyte character in data for base64 encodin
  #f(compiled-function () #<bytecode -0xccbe5ff25aca287>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name sasl-scram-sha-256-test :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/sasl-scram-rfc-t
  command-line()
  normal-top-level()
Test sasl-scram-sha-256-test condition:
    (error "Multibyte character in data for base64 encoding")
   FAILED  2/2  sasl-scram-sha-256-test (0.211032 sec)

Ran 2 tests, 0 results as expected, 2 unexpected (2021-12-20
22:36:50+0100, 0.526378 sec)

2 unexpected results:
   FAILED  sasl-scram-sha-1-test
   FAILED  sasl-scram-sha-256-test

make[3]: *** [Makefile:187: lisp/net/sasl-scram-rfc-tests.log] Error 1

Re: master a34650a: Fix sloppy base64 acceptance of some multibyte characters

[Mattias Engdegård]

20 dec. 2021 kl. 22:39 skrev Stefan Kangas <stefankangas@gmail.com>:

> This change (or some other recent change) resulted in these test
> failures:

Thank you! The code causing these failures has now been rectified.