Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397

Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397

[Stefan Kangas]

> branch: master
> commit 2dd1c2ab19f7fb99ecee60e27e63b2fb045f6970
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     gv.el and cl-macs.el: Fix bug#57397
>
>     * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
>     * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
>     try and handle symbol macros.
>
>     * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
>     Add new testcase.

I'm not sure if it's this or something else, but I'm seeing:

Test cl-lib-symbol-macrolet-hide backtrace:
  signal(ert-test-failed (((should (equal (let ((y 5)) (cl-symbol-macr
  ert-fail(((should (equal (let ((y 5)) (cl-symbol-macrolet ((x y)) (l
  #f(compiled-function () #<bytecode 0x942bd83acad84ee>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name cl-lib-symbol-macrolet-hide :document
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/cl-lib-te
  command-line()
  normal-top-level()
Test cl-lib-symbol-macrolet-hide condition:
    (ert-test-failed
     ((should
       (equal
        (let ... ...)
        '(5 ... ... 9)))
      :form
      (equal
       (5
        (6 5)
        (6 5)
        9)
       (5
        (6 5)
        (6 6)
        9))
      :value nil :explanation
      (list-elt 2
                (list-elt 1
                          (different-atoms ... ...)))))
   FAILED  15/46  cl-lib-symbol-macrolet-hide (0.000079 sec) at
lisp/emacs-lisp/cl-lib-tests.el:513

Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

>>     gv.el and cl-macs.el: Fix bug#57397
>>
>>     * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
>>     * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
>>     try and handle symbol macros.
>>
>>     * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
>>     Add new testcase.
>
> I'm not sure if it's this or something else, but I'm seeing:

Yes, it looks like this makes the cl-letf case fail:

(ert-deftest cl-lib-symbol-macrolet-hide ()
  ;; bug#26325, bug#26073
  (should (equal (let ((y 5))
                   (cl-symbol-macrolet ((x y))
                     (list x
                           (let ((x 6)) (list x y))
                           (cl-letf ((x 6)) (list x y))
                           (apply (lambda (x) (+ x 1)) (list 8)))))
                 '(5 (6 5) (6 6) 9))))

It now returns (6 5).  But...  I'm not actually sure what the semantics
with cl-symbol-macrolet + cl-letf are supposed to be, really.

Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397

[Stefan Monnier]

> I'm not sure if it's this or something else, but I'm seeing:
>
> Test cl-lib-symbol-macrolet-hide backtrace:

I believe this is now fixed.


        Stefan