unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master b5393c6 2/3: Silence undefined function warnings in eieio-tests.el
Date: Mon, 20 Dec 2021 09:38:04 -0800	[thread overview]
Message-ID: <CADwFkmnPL2TYGgBZK29hYrh2kDZHO=ucoQnOtaGi7v0n=eNNJw@mail.gmail.com> (raw)
In-Reply-To: <jwv4k738czw.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +;; Silence byte-compiler.
>> +(defun eitest-subordinate--eieio-childp ())
>> +(defun class-alloc-initarg--eieio-childp ())
>
> Hmm... I don't understand this code.
> If `declare-function` can't be used, we should have a comment
> explaining why.

Duh, I somehow forgot that I can use that also for Lisp functions.

Now fixed, thanks.

BTW, there are only four remaining warnings in the test suite if someone who
knows eieio feels like taking a look.



  reply	other threads:[~2021-12-20 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211220151236.23091.98968@vcs0.savannah.gnu.org>
     [not found] ` <20211220151238.2DADD209AC@vcs0.savannah.gnu.org>
2021-12-20 16:21   ` master b5393c6 2/3: Silence undefined function warnings in eieio-tests.el Stefan Monnier
2021-12-20 17:38     ` Stefan Kangas [this message]
2022-01-09 19:19       ` Jean Louis
2022-01-10  3:38         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnPL2TYGgBZK29hYrh2kDZHO=ucoQnOtaGi7v0n=eNNJw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).