From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master b5393c6 2/3: Silence undefined function warnings in eieio-tests.el Date: Mon, 20 Dec 2021 09:38:04 -0800 Message-ID: References: <20211220151236.23091.98968@vcs0.savannah.gnu.org> <20211220151238.2DADD209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29022"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 20 19:56:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzNpf-0007N1-8i for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 19:56:23 +0100 Original-Received: from localhost ([::1]:50150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzNpe-0003CQ-9M for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 13:56:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzMby-00026I-PR for emacs-devel@gnu.org; Mon, 20 Dec 2021 12:38:10 -0500 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:50727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzMbx-0004nm-7k for emacs-devel@gnu.org; Mon, 20 Dec 2021 12:38:10 -0500 Original-Received: by mail-pj1-f45.google.com with SMTP id gj24so10089622pjb.0 for ; Mon, 20 Dec 2021 09:38:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=DzgR+M0IY7TIMYpZvFCmwmpzxM6rR1cbBuImPG2eI78=; b=FlNfHTq1c6f4Hoktg6hAQAo5R0v4jmne/8kuGvpstcJVAcL27UJ3VqKQqSRt0KbqE2 0cW8SpR4Tl6/LoEbdq+GHgIDOObIyDD+FMdpQPTWBh19Env3+aI2sYv2xWv/JgvFCW40 psf+BgSuVNa6hknVfyaS7F9MeL06ESApWWN569Ha3tBABQw0BHim9x/lS/Zj5KmZpIkh jc0hwSyhIpltt+kd7yFEK1AdiwfArFrdlm07C13e88YYx8xQNRiT6BBxmXVDoHura6IB yRR4kIdxvirsnUeA7XfTIblLzfgm52UTazjepioJsFDc0iKWgAd6MMtKdrcHd3rDC4Lp oOQg== X-Gm-Message-State: AOAM533J7sGCe0x5kk1sip5r57v9kH0Q/pwQV3a45HCxNvKJNuKTDSrW y00dMMILSFTngACFdGmTn/Blfg6SnKyMFvsrbsg= X-Google-Smtp-Source: ABdhPJz59trC+ztAJPWvMyE1YF8pMR5g6cxRf+yBKldr23T+DmF8CJL3iy7Xw9t2QZjypVuZhAToMlJcFbe/hhv2Sus= X-Received: by 2002:a17:902:cecf:b0:141:e15d:4a2a with SMTP id d15-20020a170902cecf00b00141e15d4a2amr17345351plg.66.1640021887707; Mon, 20 Dec 2021 09:38:07 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Dec 2021 09:38:04 -0800 In-Reply-To: Received-SPF: pass client-ip=209.85.216.45; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f45.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282530 Archived-At: Stefan Monnier writes: >> +;; Silence byte-compiler. >> +(defun eitest-subordinate--eieio-childp ()) >> +(defun class-alloc-initarg--eieio-childp ()) > > Hmm... I don't understand this code. > If `declare-function` can't be used, we should have a comment > explaining why. Duh, I somehow forgot that I can use that also for Lisp functions. Now fixed, thanks. BTW, there are only four remaining warnings in the test suite if someone who knows eieio feels like taking a look.