* Re: master 1d952078c0c: Mark two tests as expensive
[not found] ` <20230915092844.1E121C051D0@vcs2.savannah.gnu.org>
@ 2023-09-15 12:37 ` Stephen Berman
2023-09-15 14:53 ` Mattias Engdegård
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Berman @ 2023-09-15 12:37 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
On Fri, 15 Sep 2023 05:28:43 -0400 (EDT) Stefan Kangas <stefankangas@gmail.com> wrote:
> branch: master
> commit 1d952078c0c45fc095795294351a4a2ee7e6c253
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
> Mark two tests as expensive
>
> * test/lisp/calendar/todo-mode-tests.el
> (todo-test-add-and-delete-file):
> * test/lisp/simple-tests.el (simple-tests-shell-command-39067):
> Mark tests taking more than 10 seconds to run on a MacBook Pro from
> 2015 as expensive.
That's surprising. On my 2019 GNU/Linux desktop with an i7-8700 CPU @
3.20GHz each of these tests takes 1 second according to the ert output
(impressionistically, todo-test-add-and-delete-file seemed faster). Can
you tell where the bottleneck is for you, maybe by profiling?
Steve Berman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1d952078c0c: Mark two tests as expensive
2023-09-15 12:37 ` master 1d952078c0c: Mark two tests as expensive Stephen Berman
@ 2023-09-15 14:53 ` Mattias Engdegård
2023-09-16 17:10 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Mattias Engdegård @ 2023-09-15 14:53 UTC (permalink / raw)
To: Stephen Berman; +Cc: emacs-devel, Stefan Kangas
15 sep. 2023 kl. 14.37 skrev Stephen Berman <stephen.berman@gmx.net>:
>> * test/lisp/calendar/todo-mode-tests.el
>> (todo-test-add-and-delete-file):
>> * test/lisp/simple-tests.el (simple-tests-shell-command-39067):
>> Mark tests taking more than 10 seconds to run on a MacBook Pro from
>> 2015 as expensive.
>
> That's surprising. On my 2019 GNU/Linux desktop with an i7-8700 CPU @
> 3.20GHz each of these tests takes 1 second according to the ert output
> (impressionistically, todo-test-add-and-delete-file seemed faster).
An even older Mac clocks in at 0.3 s and 2.5 s, respectively.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1d952078c0c: Mark two tests as expensive
2023-09-15 14:53 ` Mattias Engdegård
@ 2023-09-16 17:10 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2023-09-16 17:10 UTC (permalink / raw)
To: Mattias Engdegård, Stephen Berman; +Cc: emacs-devel
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> 15 sep. 2023 kl. 14.37 skrev Stephen Berman <stephen.berman@gmx.net>:
>
>>> * test/lisp/calendar/todo-mode-tests.el
>>> (todo-test-add-and-delete-file):
>>> * test/lisp/simple-tests.el (simple-tests-shell-command-39067):
>>> Mark tests taking more than 10 seconds to run on a MacBook Pro from
>>> 2015 as expensive.
>>
>> That's surprising. On my 2019 GNU/Linux desktop with an i7-8700 CPU @
>> 3.20GHz each of these tests takes 1 second according to the ert output
>> (impressionistically, todo-test-add-and-delete-file seemed faster).
>
> An even older Mac clocks in at 0.3 s and 2.5 s, respectively.
Hmm, thanks for these data points. My initial guess is that something
is messed up in my local configuration and is slowing things down. I've
therefore reverted the above change until I can find the root cause.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-16 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <169477012378.9031.2869766292172699485@vcs2.savannah.gnu.org>
[not found] ` <20230915092844.1E121C051D0@vcs2.savannah.gnu.org>
2023-09-15 12:37 ` master 1d952078c0c: Mark two tests as expensive Stephen Berman
2023-09-15 14:53 ` Mattias Engdegård
2023-09-16 17:10 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).