Re: master c12838c73e: * lisp/help-fns.el: Minor fixes

Re: master c12838c73e: * lisp/help-fns.el: Minor fixes

[Stefan Kangas]

> branch: master
> commit c12838c73ef161850a081f9ccea6e375b7c2f93b
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/help-fns.el: Minor fixes
>
>     (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
>     (describe-mode--minor-modes): Simplify eta-redex.
>     (find-lisp-object-file-name): Use `autoload-file`.
>     (help-fns--describe-function-or-command-prompt): Allow the user to
>     insist on choosing a function even if it appears not to exist.

This seems to lead to:

Test help-fns-test-bug17410 backtrace:
  autoload-file((autoload "foo" nil nil t))
  find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil
  help-fns-function-description-header(help-fns-test--macro)
  describe-function-1(help-fns-test--macro)
  (let ((standard-output standard-output)) (describe-function-1 func))
  (progn (let ((standard-output standard-output)) (describe-function-1
  (unwind-protect (progn (let ((standard-output standard-output)) (des
  (let ((standard-output (generate-new-buffer " *string-output*" t)))
  (let ((string (let ((standard-output (generate-new-buffer " *string-
  help-fns-tests--describe-function(help-fns-test--macro)
  (let ((regexp "autoloaded Lisp macro") (result (help-fns-tests--desc
  (closure (t) nil (let ((regexp "autoloaded Lisp macro") (result (hel
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name help-fns-test-bug17410 :documentation
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/help-fns-tests.el" "
  command-line()
  normal-top-level()
Test help-fns-test-bug17410 condition:
    (void-function autoload-file)
   FAILED   3/20  help-fns-test-bug17410 (0.000129 sec) at
lisp/help-fns-tests.el:44

Re: master c12838c73e: * lisp/help-fns.el: Minor fixes

[Eli Zaretskii]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 2 Sep 2022 17:44:30 -0700
> 
> > branch: master
> > commit c12838c73ef161850a081f9ccea6e375b7c2f93b
> > Author: Stefan Monnier <monnier@iro.umontreal.ca>
> > Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> >
> >     * lisp/help-fns.el: Minor fixes
> >
> >     (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
> >     (describe-mode--minor-modes): Simplify eta-redex.
> >     (find-lisp-object-file-name): Use `autoload-file`.
> >     (help-fns--describe-function-or-command-prompt): Allow the user to
> >     insist on choosing a function even if it appears not to exist.
> 
> This seems to lead to:
> 
> Test help-fns-test-bug17410 backtrace:
>   autoload-file((autoload "foo" nil nil t))
>   find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil

Yes, because the function autoload-file doesn't seem to exist.

Re: master c12838c73e: * lisp/help-fns.el: Minor fixes

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Yes, because the function autoload-file doesn't seem to exist.

Looks like it's supposed to be an accessor into the autoload object,
but perhaps that was forgotten in the commit?

Re: master c12838c73e: * lisp/help-fns.el: Minor fixes

[Stefan Monnier]

>>     * lisp/help-fns.el: Minor fixes
>>
>>     (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring.
>>     (describe-mode--minor-modes): Simplify eta-redex.
>>     (find-lisp-object-file-name): Use `autoload-file`.
>>     (help-fns--describe-function-or-command-prompt): Allow the user to
>>     insist on choosing a function even if it appears not to exist.
>
> This seems to lead to:
>
> Test help-fns-test-bug17410 backtrace:
>   autoload-file((autoload "foo" nil nil t))

Not sure what I was smoking back then, sorry.
Should be fixed now,


        Stefan