* Re: master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap
[not found] ` <20211117044952.7D665209BF@vcs0.savannah.gnu.org>
@ 2021-11-17 6:06 ` Lars Ingebrigtsen
2021-11-17 6:22 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-17 6:06 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
stefankangas@gmail.com (Stefan Kangas) writes:
> + ["C-c C-c"] #'bookmark-bmenu-this-window
The ["..."] syntax is no longer valid -- only the key-description syntax
is valid in defvar-keymap now. 😀
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap
2021-11-17 6:06 ` master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap Lars Ingebrigtsen
@ 2021-11-17 6:22 ` Stefan Kangas
2021-11-17 6:24 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-11-17 6:22 UTC (permalink / raw)
To: Lars Ingebrigtsen, emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> stefankangas@gmail.com (Stefan Kangas) writes:
>
>> + ["C-c C-c"] #'bookmark-bmenu-this-window
>
> The ["..."] syntax is no longer valid -- only the key-description syntax
> is valid in defvar-keymap now. 😀
Thanks. It seems like I accidentally tested this on a version of Emacs
that is not up-to-date with current master.
Sorry about that. I'll push a fix shortly.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap
2021-11-17 6:22 ` Stefan Kangas
@ 2021-11-17 6:24 ` Lars Ingebrigtsen
2021-11-17 6:27 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-17 6:24 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefan@marxist.se> writes:
> Thanks. It seems like I accidentally tested this on a version of Emacs
> that is not up-to-date with current master.
>
> Sorry about that. I'll push a fix shortly.
No prob; but I already pushed a fix. (Unless I forgot to push it again?)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap
2021-11-17 6:24 ` Lars Ingebrigtsen
@ 2021-11-17 6:27 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2021-11-17 6:27 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> No prob; but I already pushed a fix. (Unless I forgot to push it again?)
Yup, I can see your fix here. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-17 6:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211117044950.9301.95997@vcs0.savannah.gnu.org>
[not found] ` <20211117044952.7D665209BF@vcs0.savannah.gnu.org>
2021-11-17 6:06 ` master 0fd79ee: Convert keymaps in bookmark.el to defvar-keymap Lars Ingebrigtsen
2021-11-17 6:22 ` Stefan Kangas
2021-11-17 6:24 ` Lars Ingebrigtsen
2021-11-17 6:27 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).