* Re: master 52d4c98cec: Fix detection of DPI changes in builds without Xft
[not found] ` <20221028072949.AE871C00AB5@vcs2.savannah.gnu.org>
@ 2022-10-28 20:35 ` Stefan Kangas
2022-10-28 20:40 ` Vincent Bernat
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2022-10-28 20:35 UTC (permalink / raw)
To: Eli Zaretskii, emacs-devel; +Cc: Vincent Bernat
Eli Zaretskii <eliz@gnu.org> writes:
> branch: master
> commit 52d4c98cec0901ef5cc1c55d5b3b33ac9d9c519f
> Author: Vincent Bernat <bernat@luffy.cx>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Fix detection of DPI changes in builds without Xft
>
> * src/xsettings.c (apply_xft_settings) [!HAVE_XFT]: Support
> XSETTINGS changes in non-XFT builds. (Bug#43128)
This seems to lead to this warning:
xsettings.c: In function ‘apply_xft_settings’:
xsettings.c:827:3: warning: implicit declaration of function
‘cairo_ft_font_options_substitute’; did you mean
‘cairo_font_options_status’? [-Wimplicit-function-declaration]
827 | cairo_ft_font_options_substitute (options, pat);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| cairo_font_options_status
xsettings.c:827:3: warning: nested extern declaration of
‘cairo_ft_font_options_substitute’ [-Wnested-externs]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 52d4c98cec: Fix detection of DPI changes in builds without Xft
2022-10-28 20:35 ` master 52d4c98cec: Fix detection of DPI changes in builds without Xft Stefan Kangas
@ 2022-10-28 20:40 ` Vincent Bernat
2022-10-28 21:23 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Vincent Bernat @ 2022-10-28 20:40 UTC (permalink / raw)
To: Stefan Kangas, Eli Zaretskii, emacs-devel
On 2022-10-28 22:35, Stefan Kangas wrote:
>> branch: master
>> commit 52d4c98cec0901ef5cc1c55d5b3b33ac9d9c519f
>> Author: Vincent Bernat <bernat@luffy.cx>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>> Fix detection of DPI changes in builds without Xft
>>
>> * src/xsettings.c (apply_xft_settings) [!HAVE_XFT]: Support
>> XSETTINGS changes in non-XFT builds. (Bug#43128)
>
> This seems to lead to this warning:
>
> xsettings.c: In function ‘apply_xft_settings’:
> xsettings.c:827:3: warning: implicit declaration of function
> ‘cairo_ft_font_options_substitute’; did you mean
> ‘cairo_font_options_status’? [-Wimplicit-function-declaration]
> 827 | cairo_ft_font_options_substitute (options, pat);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | cairo_font_options_status
> xsettings.c:827:3: warning: nested extern declaration of
> ‘cairo_ft_font_options_substitute’ [-Wnested-externs]
It is defined in cairo-ft.h. The declaration needs to be updated:
#if defined USE_CAIRO || defined HAVE_XFT
#ifdef USE_CAIRO
#include <fontconfig/fontconfig.h>
#include <cairo-ft.h>
#else /* HAVE_XFT */
#include <X11/Xft/Xft.h>
#endif
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 52d4c98cec: Fix detection of DPI changes in builds without Xft
2022-10-28 20:40 ` Vincent Bernat
@ 2022-10-28 21:23 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2022-10-28 21:23 UTC (permalink / raw)
To: Vincent Bernat, Eli Zaretskii, emacs-devel
Vincent Bernat <bernat@luffy.cx> writes:
> It is defined in cairo-ft.h. The declaration needs to be updated:
That did it, thanks. Fix pushed to master.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-28 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166694218940.4562.15928849117026045233@vcs2.savannah.gnu.org>
[not found] ` <20221028072949.AE871C00AB5@vcs2.savannah.gnu.org>
2022-10-28 20:35 ` master 52d4c98cec: Fix detection of DPI changes in builds without Xft Stefan Kangas
2022-10-28 20:40 ` Vincent Bernat
2022-10-28 21:23 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).