unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Ugly regexps
Date: Wed, 3 Mar 2021 12:46:47 -0600	[thread overview]
Message-ID: <CADwFkmkngtJr6YmY1wqJMwsstKeu=8pd8+TBmQ7C+xbGQgPC5Q@mail.gmail.com> (raw)
In-Reply-To: <jwvsg5cgmof.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Why would someone find rx unpalatable?
>
> Maybe just because of habit, but I think the main downside of `rx` is
> that it's very verbose, which ends up hiding the "text".  For example in
>
>     (rx "(def" (or "macro" "un" "subst")))
>
> I find the `or` to get a bit in the way of my visual cortex recognizing
> the "defmacro" pattern above.

It is also just another thing to learn.

If you're just doing some basic ELisp functions for your personal
editing you might not want to spend time parsing the docstring of `rx'
just to say "^(foo|bar)".  This applies also if you're just writing some
small package that just needs a regexp or two.

Also, `rx' does not translate to most other languages.  So if you are
learning regexps for the first time or are still struggling with them,
you will IMO probably be better off staying away from `rx' for a while.
Note also that you can't use `rx' syntax in `query-replace-regexp'.

I am not surprised that we don't see `rx' used more, even if I would
certainly wish that wasn't the case.  Especially in our own sources.
(It's too bad that we don't use it in our preloaded code, for example.)



  reply	other threads:[~2021-03-03 18:46 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  0:32 Ugly regexps Stefan Monnier
2021-03-03  1:32 ` Stefan Kangas
2021-03-03  2:08   ` Stefan Kangas
2021-03-03  6:19     ` Eli Zaretskii
2021-03-03 20:46   ` Alan Mackenzie
2021-03-04 18:35     ` Stefan Kangas
2021-03-03  6:00 ` Eli Zaretskii
2021-03-03 15:46   ` Stefan Monnier
2021-03-03 16:30     ` Eli Zaretskii
2021-03-03 17:44       ` Stefan Monnier
2021-03-03 18:46         ` Stefan Kangas [this message]
2021-03-03 19:21           ` Eli Zaretskii
2021-03-03 19:50             ` Stefan Kangas
2021-03-03 20:16               ` Stefan Kangas
2021-03-03 19:50             ` Stefan Kangas
2021-03-03 19:58             ` Dmitry Gutov
2021-03-03 20:07               ` [External] : " Drew Adams
2021-03-03 20:31                 ` Stefan Kangas
2021-03-03 22:17                   ` Drew Adams
2021-03-03 22:32                     ` Stefan Monnier
2021-03-03 20:32                 ` Stefan Monnier
2021-03-04  5:47               ` Eli Zaretskii
2021-03-04 10:49                 ` Lars Ingebrigtsen
2021-03-04 11:25                   ` Mattias Engdegård
2021-03-04 11:28                   ` Alan Mackenzie
2021-03-04 14:11                   ` Eli Zaretskii
2021-03-04 14:25                 ` Dmitry Gutov
2021-03-04 14:50                   ` tomas
2021-03-04 15:04                     ` Dmitry Gutov
2021-03-05  5:45                       ` Richard Stallman
2021-03-05 11:47                         ` Dmitry Gutov
2021-03-06  5:11                           ` Richard Stallman
2021-03-04 15:05                     ` Dmitry Gutov
2021-03-04 15:11                   ` Eli Zaretskii
2021-03-03 19:32           ` [External] : " Drew Adams
2021-03-03  7:09 ` Helmut Eller
2021-03-03 14:11   ` Stefan Kangas
2021-03-03 16:40     ` Stefan Monnier
2021-03-03 15:49   ` Stefan Monnier
2021-03-03 12:17 ` Dmitry Gutov
2021-03-03 15:48   ` Stefan Monnier
2021-03-03 13:57 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkngtJr6YmY1wqJMwsstKeu=8pd8+TBmQ7C+xbGQgPC5Q@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).