Re: master 66669c5c20: Add NEWS entry about kill-buffer change

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>  * Changes in Emacs 29.1
>
> +---
> +** Interactively, 'kill-buffer' will now offer to save the buffer if unsaved.
> +

I don't understand what this means.  I thought it always did that?

Could we perhaps expand this NEWS item slightly?

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

>> +---
>> +** Interactively, 'kill-buffer' will now offer to save the buffer if unsaved.
>> +
>
> I don't understand what this means.  I thought it always did that?

Perhaps you're thinking of `save-buffers-kill-emacs'?  `kill-buffer'
(i.e., `C-x k') didn't offer to save anything.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Perhaps you're thinking of `save-buffers-kill-emacs'?  `kill-buffer'
> (i.e., `C-x k') didn't offer to save anything.

When I visit some file and make some edits in 27.1, then hit `C-x k',
I see a prompt "Buffer foo modified; kill anyway (yes or no)".  Is
that what you are talking about?

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> When I visit some file and make some edits in 27.1, then hit `C-x k',
> I see a prompt "Buffer foo modified; kill anyway (yes or no)".  Is
> that what you are talking about?

Yup.  (Now it says "yes/no/save and then kill".)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Yup.  (Now it says "yes/no/save and then kill".)

Thanks, I somehow missed that.

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> > When I visit some file and make some edits in 27.1, then hit `C-x k',
> > I see a prompt "Buffer foo modified; kill anyway (yes or no)".  Is
> > that what you are talking about?
>
> Yup.  (Now it says "yes/no/save and then kill".)

Having tested this, it is a very good addition, thanks.  It would be
even better if it respected `use-short-answers', so that I could just
hit e.g. "y", "n" or "s" in reply to this prompt.

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> Having tested this, it is a very good addition, thanks.  It would be
> even better if it respected `use-short-answers', so that I could just
> hit e.g. "y", "n" or "s" in reply to this prompt.

It's supposed to -- doesn't that work?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Manuel Uberti]

On 25/06/22 17:40, Stefan Kangas wrote:
> Having tested this, it is a very good addition, thanks.  It would be
> even better if it respected `use-short-answers', so that I could just
> hit e.g. "y", "n" or "s" in reply to this prompt.

Can you reproduce the problem from `emacs -Q`? If I do:

- emacs -Q
- Eval (setq use-short-answers t)
- Visit a file (~/.emacs.d/init.el)
- Add a blank line
- C-x k RET
- I can hit just `n` to abort the killing	

-- 
Manuel Uberti
https://manueluberti.eu

Re: master 66669c5c20: Add NEWS entry about kill-buffer change

[Stefan Kangas]

Manuel Uberti <manuel.uberti@inventati.org> writes:

> Can you reproduce the problem from `emacs -Q`?

Thanks, this works perfectly in "emacs -Q".

There is probably something going on with ivy, so I'll report it to
the maintainers of that package.  Thanks!