From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: andrea.monaco@autistici.org, emacs-devel@gnu.org
Subject: Re: When suggesting a file recovery, emacs should maybe check for actual changes
Date: Sun, 2 Oct 2022 08:07:33 -0700 [thread overview]
Message-ID: <CADwFkmkdeU1MypkB69BMTkT6FKCgGDBjask_=PHF+Nu+FpQR6A@mail.gmail.com> (raw)
In-Reply-To: <83pmfa1eq3.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> I'm asking if this is an important enough situation to add code that
> could be buggy to a feature that basically must be 110% safe?
You're right that it sounds a bit scary on the face of it.
Maybe it's okay if we do it in Emacs 30, and add tests? Adding tests
would of course be good even if we don't make any changes.
> If the file is identical, restoring from it does no harm, does it?
No, but it's somewhat jarring. Especially with files that are not under
version control.
My usual response, if I care enough about the file, is to manually make
a copy, restore the file from Emacs, and then check the diff. Now that
I think about it, this suggests another nice feature to have would be to
show the diff directly from the Emacs prompt.
next prev parent reply other threads:[~2022-10-02 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 13:33 When suggesting a file recovery, emacs should maybe check for actual changes Andrea Monaco
2022-10-02 13:47 ` Eli Zaretskii
2022-10-02 14:08 ` Stefan Kangas
2022-10-02 14:29 ` Eli Zaretskii
2022-10-02 15:07 ` Stefan Kangas [this message]
2022-10-02 15:31 ` Lars Ingebrigtsen
2022-10-02 15:53 ` Stefan Kangas
2022-10-02 15:49 ` Eli Zaretskii
2022-10-02 14:09 ` Andrea Monaco
2022-10-02 14:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkdeU1MypkB69BMTkT6FKCgGDBjask_=PHF+Nu+FpQR6A@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=andrea.monaco@autistici.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).