unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: andrea.monaco@autistici.org, emacs-devel@gnu.org
Subject: Re: When suggesting a file recovery, emacs should maybe check for actual changes
Date: Sun, 02 Oct 2022 17:29:08 +0300	[thread overview]
Message-ID: <83pmfa1eq3.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkNQphuL-S81=SHpObbObDEbtJz4tw0N8DToOUadUvBCQ@mail.gmail.com> (message from Stefan Kangas on Sun, 2 Oct 2022 07:08:52 -0700)

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 2 Oct 2022 07:08:52 -0700
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Maybe emacs should check that the auto-save file is not identical before
> >> suggesting a recover-this-file.  Do you agree?
> >
> > Why is it a problem that they are identical?
> 
> Either the user or Emacs could verify that the files are identical.
> Currently, the user has to do that work.  If it was the other way
> around, the user would not have to.
> 
> Maybe I'm missing something, but I believe that in that case Emacs
> wouldn't even have to show a prompt.  The recovery file could just be
> deleted, as it doesn't contain anything new.

I'm asking if this is an important enough situation to add code that
could be buggy to a feature that basically must be 110% safe?

If the file is identical, restoring from it does no harm, does it?



  reply	other threads:[~2022-10-02 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 13:33 When suggesting a file recovery, emacs should maybe check for actual changes Andrea Monaco
2022-10-02 13:47 ` Eli Zaretskii
2022-10-02 14:08   ` Stefan Kangas
2022-10-02 14:29     ` Eli Zaretskii [this message]
2022-10-02 15:07       ` Stefan Kangas
2022-10-02 15:31         ` Lars Ingebrigtsen
2022-10-02 15:53           ` Stefan Kangas
2022-10-02 15:49         ` Eli Zaretskii
2022-10-02 14:09   ` Andrea Monaco
2022-10-02 14:30     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pmfa1eq3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrea.monaco@autistici.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).